Closed paullj1 closed 7 years ago
Also references #243
Thanks for the contribution! Please see the code comments for a couple of stylistic issues and some more substantive ones (a nicer way to do truncation and deprecated API usage). As Hermes is affected by a regression that never got fixed in 10.12 (see my commits tonight), I'll need to do a release before 10.12 comes out on the 20th.
Also, sorry, I had to fix the [NSApp delegate]
stuff or Xcode 8 wouldn't compile Hermes, so you'll need to rebase your changes…
Okay, so there are some warnings in IB that I can't trace, but everything appears to be working now.
OK, looks great. Stuff to work on:
I never use this mode except when testing, but I realize you also can't see the current station from it — that seems like something you might want to see (and even change!) from the menu.
Yeah, so the padding works fine until the title gets too long. I have the limit in there because otherwise, the button will disappear completely if the song title is long (not ideal).
All other changes made.
OK, close enough! I'll merge and fix things up from there.
OK, added current station display in the menu (8afd32dab0b18ef6dcc8730aba368f85147dd031).
Also added a tooltip — that'll also help somewhat with long song titles that get off.
This is a great improvement and one I definitely wouldn't have done myself. I think I might actually switch to the menu bar mode now... :-)
This is really nice. Could we use the album cover also as dock icon?
BR Christof
Am 11.09.2016 um 05:12 schrieb Nicholas Riley notifications@github.com:
OK, added current station display in the menu (4ecb48ffb8f983c22821bf5f2784a5572a32af2f).
Also added a tooltip — that'll also help somewhat with long song titles that get off.
This is a great improvement and one I definitely wouldn't have done myself. I think I might actually switch to the menu bar mode now... :-)
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.