Closed chriscraig closed 7 years ago
Agreed. I'm really bad at graphics, anyone? :-)
Best I could do on short notice was a white shadow, but someone with some graphics skills could just make a nice graphic I could blend.
Is this better than nothing?
@paullj1, want to take a shot? Here's what produces the above:
diff --git a/Sources/HermesAppDelegate.m b/Sources/HermesAppDelegate.m
index 2c47bfb..b8230fe 100644
--- a/Sources/HermesAppDelegate.m
+++ b/Sources/HermesAppDelegate.m
@@ -566,6 +566,7 @@
[overlay setSize:overlaySize];
[icon lockFocus];
+ CGContextSetShadowWithColor([NSGraphicsContext currentContext].CGContext, CGSizeMake(0, 0), 30, [NSColor whiteColor].CGColor);
[overlay drawInRect:NSMakeRect(playPauseOffset, playPauseOffset,
[overlay size].width, [overlay size].height)
fromRect:NSZeroRect
Yeah, I kind of thought the same thing but I didn't want to add another image to the project. I can play with a few things, but it won't be for a few days.
That said, I think the shadow @nriley tried looks good.
I implemented that shadow and then made it much more distinct. I think it looks pretty good. Plus now you'll have the option of removing the play/pause entirely:
Looks good. Might be a few days before I get to this as I'm having a very busy week!
No worries, we've all been there!
First, I just want to say I love this app and am very thankful to the maintainers.
With that out of the way I've noticed that the pause/play icons are hard to see on top of certain album art (e.g., lots of dark gray in the image) in the Dock when that preference is chosen. I recommend that a high contrast outline be added to the icon.