search

HermesApp / Hermes

Compact macOS Pandora client that doesn’t use Flash
http://hermesapp.org/
MIT License
381 stars 99 forks source link

Separate the play/pause as its own option in the preferences #278

Closed WebVeteran closed 7 years ago

WebVeteran commented 7 years ago

@paullj1 - thank you for your recent contributions! I'd like to make a request. Separate the play/pause as its own option in the preferences. This way users can have the song artwork not be obscured. Maybe have the play/pause only show on hover? That might work nicely. screen shot 2016-09-28 at 10 47 58 am

paullj1 commented 7 years ago

Done! So it looks like hover might be possible, but I'm wondering what the use case for that would be. The only time I could think of wanting to know play/pause information would be without actually putting my cursor over top of the image (because in that case, I could just click on the icon and get that info and more).

WebVeteran commented 7 years ago

Thank you Paul! I would contribute myself, but I only do web based programming.

Sometimes there are very quiet parts of songs, and I have my speakers on very low already... so I guess the idea is anti anxiety... is it paused? did my cable go out? etc. A quick mouse over would tell me if it's playing or not. But not having the icon on the artwork at all - that's awesome enough!

I have other ideas... should I make new Issues for them?

paullj1 commented 7 years ago

Gotcha. I can play around with it. Might not be right away though.

Yup, individual feature requests should be created as separate issues.

nriley commented 7 years ago

Cleaned this up a bit in 4da4f528dd0ae2eca1e47898708f0d5f0d48698a (don't forget that 10.10 has different font metrics!). I think this is basically done, and the issue can be closed.

paullj1 commented 7 years ago

Yikes, good catch. Thanks! On Sat, Jan 14, 2017 at 09:42 Nicholas Riley notifications@github.com wrote:

Closed #278 https://github.com/HermesApp/Hermes/issues/278.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HermesApp/Hermes/issues/278#event-923237100, or mute the thread https://github.com/notifications/unsubscribe-auth/AIb5B9UfnZnn9pd3tcRDN19ynKQh6eAtks5rSOzrgaJpZM4KI7C7 .