HermesApp / Hermes

Compact macOS Pandora client that doesn’t use Flash
http://hermesapp.org/
MIT License
381 stars 99 forks source link

[Enhancement] Touchbar support #287

Open bmehling opened 7 years ago

bmehling commented 7 years ago

It would be cool to see the newer MBPs w/ Touchbars gain some Hermes goodness!

I haven't looked into the API at all, but there is a bit of a UX issue for apps like Hermes that would typically be run in the "background". Namely, the running app can push app-specific buttons on to the bar, but as soon as the focus is gone, the app buttons are gone. I'm wondering if there's a way to override that so that Hermes can always be present while playing.

Anyway, just a suggestion. Love this app.

akiss20 commented 7 years ago

Something much smaller. The touchbar play/pause button works with Hermes (which is awesome!) but it doesn't switch between the play and pause icons like iTunes or other media does. It would be awesome if it could!

Also I just discovered Hermes. It is amazingly good. Orders of magnitude better than the desktop client that Pandora puts out with Pandora One (which isn't even Retina!). Thanks so much for a great, and free, app!

bmehling commented 7 years ago

For posterity, in case this ticket ever gets interest, as an example iTunes behaves as such:

When the app is open, a 'music player' icon appears (it's not an iTunes icon, but I'm not sure if it's generic to represent any music player):

img_20170104_144100 jpg 2017-01-05 15-49-29

When you tap the icon, the control bar opens:

img_20170104_144113 jpg 2017-01-05 15-54-20

From left to right:

I think Hermes could actually do much better than what iTunes has implemented.

akiss20 commented 7 years ago

Unrelated but you can take screenshots of the touchbar with cmd+shift+6

nriley commented 7 years ago

I've done a first pass at the 'background' pieces. Play/pause works at least; will need to keep digging as to why the scrubber doesn't but right now I've got bigger fish to fry (#285).

Update: I got the progress indicator working (Apple forgot to expose a necessary constant in the SDK — oops). Unfortunately it seems I either have a choice of having a previous track button or no next track button; the Touch Bar won't display just the play/pause and next track buttons the way Hermes needs. There are commands for liking/disliking a song but they don't seem to be exposed on the Mac the way they are on iOS.

Not much to look at, but here's a screenshot (don't have a Touch Bar Mac but I had good luck testing with Duet Display and my iPad). img_0688

bmehling commented 7 years ago

I've been using this touchbar enhancement (honestly, one of the only touchbar integrations I've found useful) for a bit. Figured I'd throw my two cents in here in case anyone comes back to it... I also understand there's limitations due to the touchbar SDK/Pandora API -- just getting it all down here in case Apple/Pandora improve their support in the future.

touch bar shot 2017-05-04 at 3 07 20 pm

Really awesome app.

bpholt commented 6 years ago

I discovered this feature "accidentally" today and was delighted. Well done!