HermesApp / Hermes

Compact macOS Pandora client that doesn’t use Flash
http://hermesapp.org/
MIT License
381 stars 99 forks source link

Simple solution to post notification on termination #292

Closed brettpynn closed 7 years ago

brettpynn commented 7 years ago

Stops the stream on application termination/quit. This has the effect of posting a notification to both Growl & OS X that there has been a state change. This helps developers who are developing against Hermes, like me, to know if there is an application/play state change. If this isn't the best way to provide this notification, then I would love to work with someone to make such a notification occur when Hermes quits.

nriley commented 7 years ago

Looks good aside from that one change — if you could remove it and resubmit, that would be great. I would love to know how are you are using the Hermes notifications – is there anything public?