search

HermesApp / Hermes

Compact macOS Pandora client that doesn’t use Flash
http://hermesapp.org/
MIT License
381 stars 99 forks source link

Fixes the Hermes' dock icon resolution #294

Closed brettpynn closed 7 years ago

brettpynn commented 7 years ago

Fixes the Hermes' dock icon when disabling the "Hide Dock icon and menus" preference. If this preference is disabled the Hermes' dock icon becomes blurry. Diving deeper, it seems that the size of the dock icon was keeping the status bar icon '18' pixel size. This fix sets both the album art and Hermes' icon to both be 1024x1024, the Apple recommended dock icon size. The status bar icon is still set to the '18' size.

nriley commented 7 years ago

I can't reproduce this — can you give me some specific instructions to reproduce? Thanks!

brettpynn commented 7 years ago

Here are the steps to reproduce:

Hermes Versions tested: 1.3.0 & 1.3.1 MacBook Air (13-inch, Early 2015) (non-retina) macOS Sierra 10.12.3

Steps to reproduce:

  1. Preferences…
  2. General
  3. Uncheck ‘Hide Dock icon and menus’
  4. Uncheck ‘Use album art with play/pause as Dock icon’ (1.3.0) OR 'Show album art in Dock' (1.3.1)
  5. The Hermes’ Dock icon is now blurry (attaching screenshots)

**If Hermes opens with these two preferences already unchecked and the icon looking right, go into preferences and toggle on & off the 'Hide Dock icon and menus' setting to reproduce. (The reason for this working is that the Dock icon is taking the current size, but if the preference is toggled the '18' size is now used because the 1024x size isn't reset unless the app is closed).

With the steps above: screen shot 2017-03-30 at 9 18 12 am

With the 'Hide Dock icon and menus' checked: screen shot 2017-03-30 at 9 18 24 am

nriley commented 7 years ago

Thanks, I am now seeing a pixelated icon; it was less noticeable because I was testing on a Retina display but I can definitely see it in the app switcher if not in the Dock.

It turns out #304/#299 also fixes this and is a bit shorter so I'm closing this pull request. If for whatever reason the bug is still there for you, feel free to post a new patch.