search

HermesApp / Hermes

Compact macOS Pandora client that doesn’t use Flash
http://hermesapp.org/
MIT License
381 stars 99 forks source link

1.3.1 Play/ skip buttons on Mac keyboard dont work #302

Open roekone opened 7 years ago

roekone commented 7 years ago

I just updated to 1.3.1 and now my keyboard controls dont work. Standard wired Mac key board. Imac running Sierra 10.12.3 (16D32)

SinisterSmith87 commented 7 years ago

Here too on MacBook Pro mid 2009.

atbe commented 7 years ago

Confirming same issue after taking 1.3.1 update.

MAC: MacBook Pro (Retina, 13-inch, Mid 2014) OS: 10.12.3 (16D32)

edit: Just to add, the buttons are not being handled by Hermes at all (as if the events are not being intercepted). Instead iTunes is started when I hit play/pause buttons on my keyboard.

edit2: v1.3.0 does not have issue. v1.3.1b1 also does have the issue.

nriley commented 7 years ago

OK, probably something to do with how Apple added a documented way to do this in 10.12.2 (along with Touch Bar support) and then broke it in 10.12.3, so I ended up putting the old method back at the last minute. See if https://github.com/HermesApp/Hermes/issues/300#issuecomment-289442489 works for you? I will definitely make another release to fix this once I get a chance.

shaun10 commented 7 years ago

I can't use this either after upgrading. Is there a way to go backwards? I'm on 10.11.6 El Capitan

roekone commented 7 years ago

Confirmed. Unchecking "Control playback with media keys" in Hermes preferences the re-checking it fixes the issue in 1.3.1

roekone commented 7 years ago

@shaun10 , use Time machine to restore the Hermes file in the "Applications" folder from yesterday's backup. If you use Time machine that is

SinisterSmith87 commented 7 years ago

Uncheck and recheck works. Try it.

bmehling commented 7 years ago

Confirmed: Uncheck/Recheck of media control option resets. MBPro 13" w/ touchbar; 10.12.3 (16D32)

rayzr522 commented 7 years ago

Yep, same problem, unchecking and rechecking works like a charm.

akiss20 commented 7 years ago

Checkbox fix worked on my 2016 touchbar macbook pro

ZevEisenberg commented 6 years ago

Me too. They work for a while, then stop working, seemingly after long pauses or idle periods? I'm on 10.13.2 (17C88).

nriley commented 6 years ago

Yeah unfortunately think this is an Apple bug. Not much we can do, maybe some day they'll provide a "real" API for background playback control on macOS like on iOS. (It looked almost like that was going to happen with the Touch Bar changes but then they undid what they did a few point releases later.)

ZevEisenberg commented 6 years ago

Since unchecking and re-checking the box fixes it, can Hermes just periodically do the same thing that would happen if you uncheck and re-check the box? At least until there's a workaround. Related: is there a radar I can dupe?

nriley commented 6 years ago

Sounds reasonable, but I'm not sure how often to "do the same thing" and whether it requires that Hermes be brought to the front. I'm not aware of a Radar on this.

On Tue, Jan 30, 2018 at 03:46:01PM +0000, Zev Eisenberg wrote:

Since unchecking and re-checking the box fixes it, can Hermes just periodically do the same thing that would happen if you uncheck and re-check the box? At least until there's a workaround. Related: is there a radar I can dupe?

ZevEisenberg commented 6 years ago

Yep, unfortunately it'll be hard to test. Maybe you can simulate a media key press via Apple Events and set up some kind of long-running test to see how often it breaks?