HermesApp / Hermes

Compact macOS Pandora client that doesn’t use Flash
http://hermesapp.org/
MIT License
381 stars 99 forks source link

Bug - Customized Toolbar Resets to Default #316

Open ghost opened 7 years ago

ghost commented 7 years ago

The customized toolbar gets reset on computer restarts and Hermes crashes. Does not seem to be persistent.

ghost commented 7 years ago

More specifically, I frequently find myself adding the "Tired" button to the toolbar when it disappears. It would be nice to have it as a default button =)

nriley commented 7 years ago

Unfortunately, I am not able to reproduce this issue. I add the "Tired" button then forced Hermes to quit and it saves. Hermes doesn't do anything special with respect to saving its toolbar configuration.

If this happens again, it would be helpful to understand whether the saved toolbar configuration is as expected. You can do this in Terminal after you add "Tired":

defaults read com.alexcrichton.Hermes "NSToolbar Configuration 523691DA-3184-4F47-A885-9465F8ED1820"

The "Tired" identifier should be "ACC84F8C-7985-4757-9D76-09A92CE90D5D". Hermes seems to use automatically generated item identifiers for all but the "like" button, and I wonder if these are somehow being recomputed and causing the problem. Unfortunately I can't just add item identifiers to all of the toolbar items otherwise everyone's toolbar layouts would be lost.

I've attached a version of Hermes which has identifiers specified for all the toolbar items — let me know if it works any better for you. (Please note that as above, your toolbar will be reset essentially to the defaults when you first launch this version of Hermes.)

(Also, if Hermes is crashing please file an issue with the crash report attached!)

Hermes-1.3.2d1.zip

ghost commented 7 years ago

Cool. Thanks. I switched to that version of the app.

I will run defaults read com.alexcrichton.Hermes "NSToolbar Configuration 523691DA-3184-4F47-A885-9465F8ED1820 if it disappears from the toolbar again.