search

HermesApp / Hermes

Compact macOS Pandora client that doesn’t use Flash
http://hermesapp.org/
MIT License
382 stars 99 forks source link

Crashes after 4 skips #58

Closed cemarriott closed 12 years ago

cemarriott commented 12 years ago

Hermes crashes after I skip 4 times in a station. Fiddled with moving to different stations, then skipping, etc. Positively reproducible after skipping 4 times in a row within a station.

Only started happening after Hermes updated to 1.1.0.

Crash log: https://gist.github.com/2732134 OS X 10.7.4 Hermes 1.1.0

alexcrichton commented 12 years ago

I can't seem to reproduce this, but just to make sure, you don't hit the tired or dislike, but specifically the skip button four times in a row and it crashes? Also, does this only happen on one station or on multiple stations.

As a side note, how's your internet connectivity? Does the album art take a long time to load or do other API requests take a noticeable pause to complete?

It also looks like the stack traces are missing because I think I strip symbols during the release build, can you try this with this binary, which will hopefully have symbols in the stack trace.

cemarriott commented 12 years ago

No, I'm only hitting the skip button. I open Hermes up, switch to any station, and skip 4 times using either the media hotkeys or the skip button on the player itself.

Connectivity is good, it takes maybe 2 seconds to load the album art. Everything feels snappy and responsive.

Here's the latest log using the build you provided: https://gist.github.com/2732238

cemarriott commented 12 years ago

Now I'm getting "An error has occurred with Pandora. An unexpected error occured," and trying to play anything on Pandora's website tells me "There are no more songs to play on this station" on all of my stations. Hahahah, I'm thinking something is up on Pandora's end, then.

tresni commented 12 years ago

I'm seeing the same behavior after 4 songs play, no skips. trying a debug build to see capture output.

tresni commented 12 years ago

Crash log at https://gist.github.com/2732869

viveksjain commented 12 years ago

I'm getting the exact same thing. If it helps, my console message is at http://d.pr/n/XEzV. This is 100% reproducible for me.

tresni commented 12 years ago

So having some issued debug, but I was able to find out that AudioStreamer is getting a url which is null. This appears to be whats causing the issue. Not sure why it's getting a null at this point as it seems like XCode wants to lock up and not let me click anything when I try to debug now...

viveksjain commented 12 years ago

8c0f449 works fine. The issue was introduced in aa68b01.

alexcrichton commented 12 years ago

@tresni this might be coming out of having different quality streams coming from pandora. If you look here, can you see if any of those urls are nil?

I've had a lot of problems with xcode, which is why I started to use a Makefile to build/run hermes, the make dbg target will give you a gdb session.

alexcrichton commented 12 years ago

Also, if you're having problems, does removing ~/Library/Application Support/Hermes fix the issue?

viveksjain commented 12 years ago

I think I figured out what the problem was. The JSON from Pandora has one last item that is only an adToken, and Hermes was trying to process it as a song. Not sure why you weren't seeing any problems, @alexcrichton. My commit should fix this.

viveksjain commented 12 years ago

Thanks for pointing me in the right direction @alexcrichton. And I also had problems debugging, both with XCode and with GDB…I had to restart a few times because my computer hung. Seems like NSLog is the only reliable option :( .

alexcrichton commented 12 years ago

Thanks @viveksjain for finding a fix to this! Turns out that because I'm using pandora one that those don't pop up in the JSON returned...

alexcrichton commented 12 years ago

Version 1.1.1 contains the fix.