HeroCreationLab / hero-creation-tool

Step-by-step module tool for creating 5e characters in FoundryVTT
MIT License
29 stars 15 forks source link

Conflict with Variant Encumbrance Module v9 #129

Open Dialectikal opened 1 year ago

Dialectikal commented 1 year ago

Module Version: v1.8.3 Browser: Chrome Foundry Version: 9.269 Game System: DnD5e 1.6.3 Variant Encumbrance Version: 0.10.3

It seems that while the Variant Encumbrance module is active, there is an issue with editing items on any actor that was created using the Hero Creation Tool module. If I create an actor normally, dragging items to the character sheet, there is no issue. But any items that were added as part of the Hero Creation Tool can't be edited or removed as long as the Variant Encumbrance module is activated.

I also get the following error: image

There must be something different about how the Hero Creation Tool is adding items to character sheets.

This only occurs with the Variant Encumbrance module activated. The dependencies don't cause any issues. I have used Find the Culprit as well, to eliminate the possibility of other conflicts.

ccjmk commented 1 year ago

Hi! I'm currently a little unavailable due to some personal stuff, but I will look into this asap

Dialectikal commented 1 year ago

I raised an issue on the Variant Encumbrance module as well, but I suspect it will have to be handled here. It seems this module is treating those items differently.

Dialectikal commented 1 year ago

Hey, have you had a chance to take a look at this at all? If you have an idea where the issue might lie, I could try to resolve it locally for now.

ccjmk commented 1 year ago

Sorry, not yet! I'm in the middle of moving so it might take some more time than usual

On Thu, Nov 3, 2022, 5:19 PM Dialectikal @.***> wrote:

Hey, have you had a chance to take a look at this at all? If you have an idea where the issue might lie, I could try to resolve it locally for now.

— Reply to this email directly, view it on GitHub https://github.com/HeroCreationLab/hero-creation-tool/issues/129#issuecomment-1302352976, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCCTOCYHSEA7E6NDOD6XFDWGPQZZANCNFSM6AAAAAARJYPNBU . You are receiving this because you commented.Message ID: @.***>

ccjmk commented 1 year ago

Hi! Sorry for the loooooooooooooooong delay, I just finished setting up shop unfortunately. I tried this but was unable to reproduce it; the module you mention is Variant Encumbrance+Midi right ? I couldn't find another one. I created a character as default, and one with the HCT, both with a battleaxe (added the axe on the default after creation, on the module one I selected it through the equipment tab), and then changed their names both. I am also able to delete them. I don't know if I need to do something else with the module, I just see it as "enabled" on its module settings.

image

Feel free to reach me on Discord, so we can try and see this together.