HeroCreationLab / hero-creation-tool

Step-by-step module tool for creating 5e characters in FoundryVTT
MIT License
31 stars 15 forks source link

Duplicated Passive Effects #133

Closed MythicalRollers closed 1 year ago

MythicalRollers commented 1 year ago

Foundry: 10.291 dnd5e: 2.1.4 Hero Tool: 1.9 When racial features have passive effects built into them, the first one which is applied is duplicated. The effect is listed twice, while the feature is still only listed once. effects

ccjmk commented 1 year ago

Hi @MythicalRollers ! This seems like an issue from imported sources; as you can see, DDBImporter brings sometimes two races with the same name from different books, each with their own set of abilities. The tool is not designed to work with multiples of the same race, so this is not a bug itself.

image

I am closing this as a bug because I see no evidence of an issue so far, but we can reopen it with new evidence.

MythicalRollers commented 1 year ago

Hey homie! I've got that sweet sweet evidence you wanted. Custom race, custom trait, no duplicates in the compendiums and images to show it. I did make the race twice, only to be able to show you the traits themselves are listed once on the character sheet, but the effect is duplicated. So you have custom race "Drowimar", custom trait "Love of Life", and then actor "Drowimar" and "Drowimar2". DrowimarSnip

ccjmk commented 1 year ago

Oooh I see, it's the effects! My bad, it's in the literal issue title facepalm I read this without my coffee apparently hahah ok that looks fishy, I'll investigate asap

ccjmk commented 1 year ago

Ok! now testing Effects for real hahah I still can't replicate this:

image

Keeping this open this time while I investigate some more. I found on MrPrimate's discord someone reporting a similar bug that seems to relate to DAE, you have that module enabled?

https://gitlab.com/tposney/dae/-/issues/365

EDIT: I just gave this a quick test with DAE installed and enabled, and it seems to be the case: (but only for new characters, existing PCs should be good)

image

Just to be sure, can you confirm if you have the module installed & enabled, trying disabling it and creating a new character? If this is the case, then this looks like a bug on their side, and I can close this one for real this time, at least with a happier ending! :D

MythicalRollers commented 1 year ago

Well biscuits! You are correct, disabling DAE makes these work without duplicates. Bug can officially be closed. Thank you! Incase anyone else has this issue, reverting back to DAE 10.0.15 fixed it for me. I couldn't find an active .json for it, so I had to manually revert. https://gitlab.com/tposney/dae/raw/v10/package/dae-v10.0.15.zip