HeroCreationLab / hero-creation-tool

Step-by-step module tool for creating 5e characters in FoundryVTT
MIT License
31 stars 15 forks source link

Some items don't open the popup when clicked #22

Closed SecretSquirrel77 closed 2 years ago

SecretSquirrel77 commented 3 years ago

Background

Backgrounds can be selected, but don't display in the text box. For example, in the screenshot, 'acolyte' is selected, but it does not display in the box to the right.

ccjmk commented 3 years ago

oooh I see what you mean. I didn't realise this would be confusing, but its the "standard" behaviour right now: the text box is only shown when you select to create a new feature.

If you select an existing feature, you should be able to click it and see the item pop-up. If I add the text description here, it would then differ from Race/Class features, that also don't show their description.

SecretSquirrel77 commented 3 years ago

I understand what you mean now. I am not able to open the background item by clicking on it however. Is there something I'm missing?

ccjmk commented 3 years ago

Hmm ok, I seemed to have missed something here definitely. From what I could tell on my testing, CREATED items (so, race features or class features, backgrounds, spells) don't pop up the window, some throw an error, some don't. It only works for "default" items, and the ones from DDBImporter also work. So I might be messing up something on my side here, marking this as a bug.

Though rest assured that the items ARE adequately added to the created actor, it's just the visualization that is a little iffy.

ccjmk commented 3 years ago

Renaming the issue because I keep coming back to it trying to remember what's wrong in here hahah

ccjmk commented 2 years ago

got it! going into next version