Closed MaxPat931 closed 3 years ago
@MaxPat931 version 1.1.3 should fix this, at least according to my testing! Let me know how it works for you, in case I needed to fix something else i missed.
@ccjmk This did fix the above issue, but it also changed the behavior for multiple instances of the same race. Because the Parent Race cannot be selected when there are subraces available, I would have 2 instances of a Parent race if it should be a playable option. Previously, the module would only place the subraces under one version, and the other would be treated as a separate race.
1.1.2
But now, the subraces are listed under both instances of the Parent Race 1.1.3
This applies to Half-Elf, Half-Orc, Human, and Tiefling (from my DDB resources)
@MaxPat931 im a little torn on this one. I consider that not been able to select the parent race is "expected behaviour". You can't be a "Dwarf" without been a mountain/hill/etc dwarf, for example. There just isn't a "not-subrace" dwarf. Same for other races. Variant races do pose a problem to this though, but I think the best solution is to create a "Vanilla" or default race.
For example, in the case of Humans from your screenshot, I think like just like you have all the Mark of * and Variant Human, there should be an extra one as "Default" or just.. Human maybe. But technically speaking, that would be a "Human" subclass.
That said, I think that the expected behaviour here would be either not showing any consecutive repeated race I find while iterating through the parent races list (so the whole second Human... would be ignored - but this would probably cause some usability issues where people have a repeated race not realizing it, and the module picks the one they don't want without them realizing), or simply leaving everything as-is, and if you repeat a race, you see them repeated (an error, but an easier error to see for the user)
As far as I understand from DDBImporter, each of their races have the whole content of both parent race and subrace, so the parent race is "not needed" but its actually required by this module to order stuff. What could probably work is just copying the SRD human race into a custom races compendium on your world, create an empty "Human" base race, and set the SRD copied race to be a subrace of that. That way, you can pick the "default" human as a subclass of human, and the DDBImporter ones will also be appropriately ordered while not adding anything undesired.
DO NOTE that this will probably change once dnd5e system implements Race items, because there both my module and DDBImporter will probably be able to do a better job keeping these things ordered.
Please, let me know your thoughts on this one so I can gauge what's the user expectation too
Yea, it looks like just adding the Human requirement to my ddb imported Human sorted it well. I am assuming the Parent is the SRD Human, and then everything looks fine.
However, now I checked what happens with duplicate subraces, and it seems that it just pulls the first subrace it finds but displays it twice. Both of the options for Lightfoot Halfling in the drop down point to the SRD race, cant get to the DDB race. But I do agree that any duplicate race should be displayed for the reasons you described.
But I think the proper way to do this with DDB will be to do what you described and copy over all Parent Races from the SRD (Dragonborn, Dwarf, Elf, Gnome, Half-Elf, Half-Orc, Halfling, Human, Tiefling) into my DDB folder, and not point the tool to the SRD at all. Also update the DDB imported races for "vanilla" Human, Tiefling, Half-Elf, Half-Orc, and Dragonborn to have the requirement field set to the same race.
everything looks good now
One last thing, which would probably be another ticket, but it would be nice if the selector was a filter instead of just a drop down. Like if I start typing "half" it only shows races with "half" in them.
MrPrimate is aware of some odd interactions with my module, so we can probably work something out; its just a matter of thinking ahead and seeing where's the easiest and most reasonable change, if making an exception here or there.
The second one should definitely be another ticket, it was something I had in mind already but please feel free to make the ticket so we can keep track of it!
So, after our conversation, i gather that this is no longer an ongoing bug, closing this ticket!
I think the only thing unresolved is the matching subraces from different compendiums, having both listings point to the same record. But could be chalked up to improper setup I guess.
All my Half-Elf races are being listed under the Elf, even though the prerequisite is set to Half-Elf