search

HeroCreationLab / hero-creation-tool

Step-by-step module tool for creating 5e characters in FoundryVTT
MIT License
31 stars 15 forks source link

Change Dropdown lists to Search Fields #38

Closed MaxPat931 closed 3 years ago

MaxPat931 commented 3 years ago

Change the Dropdown lists for Race, Class, and Backgrounds to a Search Field for easier filtering. Being able to type in the option you want will help speed up the process of finding selecting your desired feature eg typing "Half" to display only races with matching text in the list. Although it would be nice to display the whole list by default with no text input, only filtering if you type (unlike the spells and items Search Fields, that only display matching text)

image

ccjmk commented 3 years ago

def wanted to do this, i just went for a select because it was an easier solution for a 1st version. I will eventually make this change

ccjmk commented 3 years ago

Working on this now, I will make the change for Race and Class for now, I will wait and see how Background items progress on dnd5e core before making any significant change to that tab.

ccjmk commented 3 years ago

Looks ready for next version. I will close this and do some final tests just in case.

MaxPat931 commented 3 years ago

Looks great to me! And resolves the "Parent Class" sorting stuff from earlier as that is basically irrelevant now that things dont really need to be sorted by those groups.

BTW looks like you mixed up the issue numbers in the changelog, but that's not really a big deal

ccjmk commented 3 years ago

It doesn't need to be sorted by parent but I do still need to keep an eye of which is the parent race internally, else I wouldn't be able to add the parent's features!

Also lol yeah thanks for the notice!

MaxPat931 commented 3 years ago

Oh good point, and I didnt realize that it looks like you're hiding that parent race now too, which I think is a good idea, but it might not be clear to another user that they are necessary, since they wont see them.