search

HeroCreationLab / hero-creation-tool

Step-by-step module tool for creating 5e characters in FoundryVTT
MIT License
31 stars 15 forks source link

Problem with the spellcasting class feature #94

Closed leagueoffoundryvttdevs closed 2 years ago

leagueoffoundryvttdevs commented 2 years ago

Submitted By: Discord IAR18#8415 Feedback Type: Bug

Core: 9.249 System: dnd5e v1.5.7 Module Version: hero-creation-tool v1.7.1

Description: When classes are translated to spanish, the hero creation tool does not detect that it is a spellcasting class, even if they give you the spellcasting feature

Additional Details

undefined

ccjmk commented 2 years ago

Oops! It is indeed using the names in english, forgot to i18n that. Will do asap!

On Tue, Mar 1, 2022 at 3:59 PM League of Foundry VTT Devs Bug Reporter < @.***> wrote:

Submitted By: Discord IAR18#8415 Feedback Type: Bug

Core: 9.249 System: dnd5e v1.5.7 Module Version: hero-creation-tool v1.7.1

Description: When classes are translated to spanish, the hero creation tool does not detect that it is a spellcasting class, even if they give you the spellcasting feature

Additional Details

undefined

— Reply to this email directly, view it on GitHub https://github.com/HeroCreationLab/hero-creation-tool/issues/94, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCCTOF7DM4WIIYSA24EZL3U5Y5FFANCNFSM5PUOJR5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

ccjmk commented 2 years ago

On further investigation, it should actually take the hint from the class item itself, not relying on any Spellcasting/Pact Magic item. i will fix it that way!

Darshyne commented 2 years ago

Yes i have the same issue with french translation, anyway this module is very promising :)

ccjmk commented 2 years ago

Putting this on hold as there's an open ticket that will impact how this works, and Advancements have already messed up how this could be fixed, so I will wait and fix it once instead of fixing it again later

https://gitlab.com/foundrynet/dnd5e/-/issues/1540