search

HeroOfTheWinds / minetest-caverealms

A mod for Minetest to add underground realms
17 stars 14 forks source link

Dev #3

Closed Zeno- closed 10 years ago

Zeno- commented 10 years ago

Just some ideas.

Have a look at 553f197 as well... I started to restructure the code so it is (IMO) a bit more readable (far fewer conditionals)

As for 7ee7b6a, I don't know about this one... when testing with the new HDX textures things didn't work as expected (I'll look into some more)

A request: can the texture for mycene_essence be renamed mycene_powder? The reason for this is that I'll use the same HDX textures as I do for my mod and I already have mycene_essense, which makes things a tad confusing

Cheers

HeroOfTheWinds commented 10 years ago

Everything seems alright here. I especially like the cleanup you did on stalagmite/ctite functions, even easier to expand than before! I can't look at the random gem sizes right now (not on a system with MT) but I'm sure they're fine. Can always change it later. :) Thank you!

HeroOfTheWinds commented 10 years ago

Tried merging the branch, but the changes are too spread apart. I'll see what I can do tomorrow. :/

Zeno- commented 10 years ago

Cool. The stalagite/tite changes will have to be reviewed (apart from the conflict resolutions) anyway -- basically because I started doing the changes before I checked your latest commit (oops). Even with the latest commit it shouldn't be hard to do.

HeroOfTheWinds commented 10 years ago

I'll go ahead and manually merge the commits and then push a new one. I'll close this request once that is complete.

HeroOfTheWinds commented 10 years ago

Alright, made the changes, although there were a couple errors with the stalagmites/ctites I had to fix; namely, the bases differed from my original design (stone on the bottom with a layer of crystal ore, then the crystal), and your biome reference tables were backward, making the secondary crystal type the primary type. (Lots of mese, hehe :D) Otherwise, nice work!