Presented viewController doesnt deinit when dismissing - Githubissues

HeroTransitions / Hero

Elegant transition library for iOS & tvOS

https://HeroTransitions.github.io/Hero/

MIT License

22.05k stars 1.73k forks source link

Presented viewController doesnt deinit when dismissing #693

Open hurtado-truelogic opened 3 years ago

hurtado-truelogic commented 3 years ago

What did you do?

Created a new ViewController through storyboard.
Activated Hero (isHeroEnabled = true)
presented the view through UIKit present() method, `animated = true
Presented correctly`
Dismissed the view using Hero.shared.defaultAnimation = .fade and hero_dismissViewController()

What did you expect to happen?

The view controller to be dismissed AND removed from memory running the deinit{} method

What happened instead?

On next presentation, it presents the view controller at the exact same state as before.

General Information

Hero Version: 1.5.0
iOS Version(s): 14.2
Swift Version: 5
Devices/Simulators: Simulator (iPhone 8)
Reproducible in Examples? (Yes/No): No

rxvincent commented 3 years ago

Seems that when dismiss is performing, it will assign you dismissing viewController in Hero.shared. fromViewController (in HeroTransition.swift). I use unwind more than dismiss, so modify source code and clean Hero.shared. fromViewController after everything done is ok for me.

Hope it will help you