search

HeroTransitions / Hero

Elegant transition library for iOS & tvOS
https://HeroTransitions.github.io/Hero/
MIT License
22.02k stars 1.72k forks source link

SPM integration causes compiler Issues, preventing the project from building #704

Closed joshwoods closed 3 years ago

joshwoods commented 3 years ago

What did you do?

Installed Hero via SPM and then was not able to actually build the project. See screenshot below.

What did you expect to happen?

The project should be able to build, however, there are multiple issues throughout the project when integrating via SPM.

What happened instead?

Screen Shot 2021-02-20 at 4 23 36 PM

General Information

Demo Project

test.zip

JoeMatt commented 3 years ago

SPM is strange with imports. Probably need to add missing import Foundation, import CoreGraphics.

I had added a bunch and it was building with SPM before my merge. I'll check out your sample project, thanks.

JoeMatt commented 3 years ago

@joshwoods Can you point your SPM config to branch feature/704_SPM_Fixes and see if it's fixed please.

z3bi commented 3 years ago

I was having the same issue but was able to build with SPM using feature/704_SPM_Fixes