HeroTransitions / Hero

Elegant transition library for iOS & tvOS
https://HeroTransitions.github.io/Hero/
MIT License
22.06k stars 1.73k forks source link

unwindToViewController not working in iOS 15 #724

Open rued opened 3 years ago

rued commented 3 years ago

What did you do?

I have VC1 -> VC2 -> VC3 I use VC3.hero.unwindToViewController(VC1) to unwind.

What did you expect to happen?

With iOS 14 and earlier, this has been working fine, I see a smooth transition from VC3 -> VC1

What happened instead?

After upgrading to iOS 15, the unwind DO happen, but the animation is from VC3 -> VC3, and when done an instant switch to VC1.
debugger reports: 'Unbalanced calls to begin/end appearance transitions for VC3'

General Information

Demo Project

None

rued commented 3 years ago

I might add that I'm not using Navigation controllers.

VC2 & VC3 are opened using:

let controller = XXXViewController() // isHeroEnabled = true is set in viewDidLoad controller.modalPresentationStyle = .fullScreen controller.delegate = self controller.datasource = self controller.heroModalAnimationType = .selectBy(presenting:.slide(direction: .left), dismissing:.slide(direction: .right)) self.present(controller, animated: true)

varunpm1 commented 3 years ago

I have seen one more issue on iOS 15 with similar steps. I see a black screen when dismissing and I have attached example project as well - https://github.com/HeroTransitions/Hero/issues/721

LeonBiters commented 2 years ago

I also encountered the same problem. How did you solve it?