search

HeroTransitions / Hero

Elegant transition library for iOS & tvOS
https://HeroTransitions.github.io/Hero/
MIT License
22k stars 1.72k forks source link

Cell Transition animation does not work on iPhone 13 Pro #729

Closed raduncicen closed 2 years ago

raduncicen commented 2 years ago

What did you do?

I'm using transition animation from collectionView cell to new viewController.

What did you expect to happen?

The cell to expand and turn into the view controller

What happened instead?

This feature works in general but for some reason it does not work on iPhone 13 Pro devices. The view controller gets presented without any animation. Honestly I'm not sure what the reason for it to not work and whether there are other devices that has the same problem. But I have tried this on multiple iPhone 13 Pro devices and the result was same.

Note: The animation does not work when presenting view controller but works when you dismiss the presented controller. So the view controller shrinks and fits inside the cell.

I have tried it in iPhone 7 IOS 15 and it works However, it does not work on iPhone 13 Pro IOS 15 devices.

raduncicen commented 2 years ago

Apparently, I need to push it inside DispatchQueue .main, otherwise it only causes issue in some devices 🤷‍♂️