HeroTransitions / Hero

Elegant transition library for iOS & tvOS
https://HeroTransitions.github.io/Hero/
MIT License
22.06k stars 1.73k forks source link

animations won't work after switching and switching back on tabBarController #733

Open SaeeSaadat opened 2 years ago

SaeeSaadat commented 2 years ago

What did you do?

I have a main navigationController in my app that navigates between login page and the main tabBar. the tabBar it self has two child controllers which are both navigationControllers

there is this weird thing with "isHeroEnabled" in the navigationController where if i set it to true in viewDidLoad, hero animations won't work! but if i don't touch it it'll work fine! but that's not the problem!

when the tabbar loads the first page works perfectly fine with all the animations and everything! the problem begins when i switch to next tab and then go back to my first page and find it with no animation! it just awkwardly slides to right to show the next viewController as if hero is not enabled (tho i checked and indeed it was enabled for both vc's and the navigation controller)

What did you expect to happen?

for animations to work!

What happened instead?

they did not!

General Information

SaeeSaadat commented 2 years ago

https://user-images.githubusercontent.com/61188645/161418895-cf9a231a-db6e-4e4d-b13f-2d59c786219a.mov

here's a little demo of what's happening! btw you see how everything FLASHES while the transition is happening! what's that all about? it's like everything get's 1.0 alpha and then goes back to normal it's weird!