search

HeroTransitions / Hero

Elegant transition library for iOS & tvOS
https://HeroTransitions.github.io/Hero/
MIT License
22.06k stars 1.73k forks source link

Hero 1.6.x Xcode 16 Carthage #776

Open daywalkel2 opened 1 month ago

daywalkel2 commented 1 month ago

Hero SDK not compiling with Carthage in Xcode 16 or 16.1 beta.

/Users/xx/xx/xx/xx/Carthage/Checkouts/Hero/Hero.xcodeproj: warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 10.0, but the range of supported deployment target versions is 12.0 to 18.1.99. (in target 'Hero (iOS)' from project 'Hero') note: Disabling previews because SWIFT_VERSION is set and SWIFT_OPTIMIZATION_LEVEL=-O, expected -Onone (in target 'Hero (iOS)' from project 'Hero') ARCHIVE FAILED

The following build commands failed: CompileSwift normal arm64 (in target 'Hero (iOS)' from project 'Hero')

daywalkel2 commented 1 month ago

Here is the line that prevent build in Xcode 16.

// capture a snapshot without alpha, cornerRadius, or shadows let oldMaskedCorners: CACornerMask = { if #available(iOS 11, tvOS 11, *) { return view.layer.maskedCorners } else { return [] } }()

JoeMatt commented 1 month ago

I'm very busy with another project at the moment, could you make a pull request for this?

daywalkel2 commented 4 weeks ago

Hi, i couldnt't create a PR cause it gives me permission denied error. But i can send u the patch diff.

On Thu, Oct 10, 2024 at 9:30 PM Joe Mattiello @.***> wrote:

I'm very busy with another project at the moment, could you make a pull request for this?

— Reply to this email directly, view it on GitHub https://github.com/HeroTransitions/Hero/issues/776#issuecomment-2405782581, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANFZDHB4YDPENHOABIN6VZTZ23BVXAVCNFSM6AAAAABOPL4RCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBVG44DENJYGE . You are receiving this because you authored the thread.Message ID: @.***>