search

Heroes-Profile / heroesprofile-api-public

6 stars 0 forks source link

Request - League Tier where MMR is a property #56

Closed jared-craig closed 2 years ago

jared-craig commented 2 years ago

I noticed some endpoints return League Tier and MMR while others sometimes just return MMR. Would it be possible to add the League Tier property wherever MMR is returned as well?

Zemill commented 2 years ago

Ya I see no reason I cant add that. I will take a look at that later today

Zemill commented 2 years ago

@jared-craig Which endpoint specifically are you facing issues with

jared-craig commented 2 years ago

The one specific to my needs was Player/Hero/All. I can't remember if there were others as well.

Zemill commented 2 years ago

So for that particular set of data, I do not expose the league tier on the websites Player/Hero/All page. I try not to present more information through the API than you can get through the live site

jared-craig commented 2 years ago

Okay. Just seems a little odd because you can sort of get that result if I were to say loop through all the heroes with the Player/MMR/Hero endpoint. Whatever you decide though, I'm okay with. Thanks!

Zemill commented 2 years ago

That is true, but its the same thing on website

Zemill commented 2 years ago

This has been added

jared-craig commented 2 years ago

Hey Zemill, Thank you. I noticed it appears in the json format but not in the csv format.

Zemill commented 2 years ago

Hey Zemill, Thank you. I noticed it appears in the json format but not in the csv format.

Fixed