Heroes-Profile / heroesprofile

Heroes Profile website public repository
https://www.heroesprofile.com/
18 stars 2 forks source link

Account Menu Box #940

Open Frankpro42 opened 8 months ago

Frankpro42 commented 8 months ago

Describe the bug There should be a Menu slider on MistyKat (NA) next to lucifer (NA).

To Reproduce Steps to reproduce the behavior:

  1. Go to link
  2. Click on Yrel Icon.
  3. Top right, cursor on lucifer (NA) next to Find Player.
  4. Click on Friends and Foes.
  5. Click on MistyKat.
  6. Notice at the top right, her name doesn't appear.

Expected behavior The Account Menu Box should appear the same as looking into a profile from Find Player and clicking on a hero portrait from a recorded game.

Screenshots link

Desktop Chrome version Version 122.0.6261.111

Zemill commented 8 months ago

Odd...I am able to replicate.

The code for this is the same between pages

For Match Single it uses a GroupBox for displaying Hero images with account info https://github.com/Heroes-Profile/heroesprofile/blob/e65d377afc68a9bb4e692ac234602192ba6cd1e4/resources/js/components/GroupBox.vue#L14

<a v-if="!esport && match && playerlink && item.hero && !item.check" class="link cursor-pointer" @click="this.$redirectToProfile(item.battletag, item.blizz_id, item.region, false)" :href="/Player/${item.battletag}/${item.blizz_id}/${item.region}">

And then for FriendFoe page https://github.com/Heroes-Profile/heroesprofile/blob/e65d377afc68a9bb4e692ac234602192ba6cd1e4/resources/js/components/Player/FriendFoe.vue#L53

<a class="link" @click="this.$redirectToProfile(row.split_battletag, row.blizz_id, row.region_id, false)" :href="/Player/${row.battletag}/${row.blizz_id}/${row.region}" >{{ row.battletag }}

Initial investigation shows no real difference between the two.

The extra player menus are handled through the this.$redirectToProfile function which calls a function out of app.js https://github.com/Heroes-Profile/heroesprofile/blob/e65d377afc68a9bb4e692ac234602192ba6cd1e4/resources/js/app.js#L25

So the code for that shouldnt be any different between the two pages....odd