search

Heroic-Games-Launcher / HeroicGamesLauncher

A games launcher for GOG, Amazon and Epic Games for Linux, Windows and macOS.
https://heroicgameslauncher.com
GNU General Public License v3.0
8.25k stars 433 forks source link

Alternative GOGDL Binary not working #1057

Closed redromnon closed 2 years ago

redromnon commented 2 years ago

Describe the bug

The Choose an Alternative GOGDL Binary to use doesn't save the path to the gogdl's binary location. It instead tries to save in Choose an Alternative Legendary Binary and says Invalid under the field (since it doesn't find a legendary binary but a gogdl one).

Add logs

Nothing related to specifying alternative GOG binary shows in the log.

Steps to reproduce

  1. Go to Settings
  2. Under Global Settings
  3. Click on folder icon in Choose an Alternative GOGDL Binary to use
  4. See error

Expected behavior

Display and store the path to the gogdl's binary location

Screenshots

Heroic_alt_GOG_binary_issue

System Information

Additional information

None

imLinguin commented 2 years ago

Don't know if it matters but on the screenshot you pasted the location in Legendary field.

redromnon commented 2 years ago

I've uploaded a video for better clarity. Here's what happens -

https://user-images.githubusercontent.com/74495920/157199030-00b9d235-06a7-4732-b3db-28dcd64c57f5.mp4

imLinguin commented 2 years ago

You are right. This issue is present only when using the file picker, I made a typo here.

https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/blob/main/src/screens/Settings/components/GeneralSettings/index.tsx#L216

flavioislima commented 2 years ago

Yes, I will fix it on my PR.