Closed not-a-dev-stein closed 3 years ago
Good! Will be live on next release!
Just released new version, check how are the icons. If you use plasma, you will need to change the GTK theme for it to work.
Just downloaded it, didn't even need to change themes for it to work. Looks nice, but I think using .svg files instead of .png ones will scale better with the tray's size.
Uploaded them just in case: https://drive.google.com/drive/folders/11pEAnRcCKya67lwrnDe7iJVWPZtJwyPD?usp=sharing
I requested access. One thing I needed to do was to resize the image because using the original size was giving me too much aliasing. A SVG might be better.
So, SVG is not supported for tray icons. So I did convert the SVG to PNG and I think looks better now. You will be able to check on next version
So, SVG is not supported for tray icons.
Oh, I didn't know that. Glad it at least was useful, hope it ends up looking good :)
was going to point this out sometime. I use a dark desktop and the icon is dark, doesn't really work :)
Tried /home/theriddick/.config/gtk-3.0/settings.ini Materia Materia-dark breeze-dark breath-dark
Tray Icon is still dark... :(
Often this sort of oddness is a plasma icon auto shading thing.
This is me using Breath-Dark on plasma:
Same here with Papirus, both regular and dark, works just fine.
I use Manjaro-Materia-Dark theme
Had some time this week to work on some visual improvements on the logo.
So I ended up with these:
Decided to close the lines since it wasn't clearly visible in the tray and went with thicker lines and more consistent spacing to make it clearer in the system tray. Even tested it using the file manager itself to compare:
It's still not perfect, but at least I see it as a big improvement in visibility.
Nice, I was about to ask you to 'close' the lines as well. Really good. I'll change for the next release this weekend.
The black one is what I get in dark theme, can't see it until I hover over icon and it turns to the lighter color version. So I dunno why its picking wrong shade. No other apps have a issue so far.
Firstly nice work on the logos and Heroic generally! But I am having the same problem as jarrard where the logo is currently invisible in the system tray unless hovered over. I'm using Cinnamon desktop with Mint-Y-Dark theme.
I've just edited the images myself to have a base background so it shows up.
@not-a-dev-stein maybe having a base color background might be a good idea to solve these edge cases. I forgot to add the new icons on the new release, sorry for that, but the translation took me a lot of time to finish. But I can put them on a hotfix but would be good to test with different environments first.
To manually test, you just need to replace the icons on this folder:
/opt/heroic/resources/app.asar.unpacked/build/
And reopen Heroic.
Cool I have tried that on my system and found for me it uses the 'right' colour icon when I swap the names around from what they were by default, i.e. naming the black icon icon-dark and the white one icon-light
Cool I have tried that on my system and found for me it uses the 'right' colour icon when I swap the names around from what they were by default, i.e. naming the black icon icon-dark and the white one icon-light
Thats one of the amazing things of Linux. You have a white theme but the bar is dark.
I think the best way to solve this is to add an option on Heroic to choose the color of the icon. Automatically it will never work on all desktops with the amount of different themes that we have.
Hey guys! I'll convert this into a discussion for further improvements on the icons.
With the project now having made a name for itself (and gaining more and more traction) I think a new logo could come in handy, or at least an updated tray icon. The logo we have until now is okay, but having no transparency in the background makes it stick out a lot in there.
So I took a little time to brainstorm an updated version without changing too much of the original idea, and here it is.
And also created a light-dark variant for the system tray: Light version; Dark version.
This is totally not ready to use material, but more of an idea of how, if redesigned, how it should look. Chose colors similar to the Epic Games Store logo in order to sell the similarities of the launcher, while we don't get other launchers integrated with it.
If needed for something I can also upload the original .svg files for quick editing.