search

Heroic-Games-Launcher / HeroicGamesLauncher

A games launcher for GOG, Amazon and Epic Games for Linux, Windows and macOS.
https://heroicgameslauncher.com
GNU General Public License v3.0
8.25k stars 433 forks source link

Gogdl Issues don't fail gracefully #1125

Closed miketweaver closed 2 years ago

miketweaver commented 2 years ago

Describe the bug

When you go to download a game and gogdl has an error, the heroic launcher just sits at the spinning icon. It doesn't report to the user that there has been an error or what that error was.

image

Add logs

When you view debug: image

Relevant logs:

(20:23:35) ERROR:   [Gog]:             Info command failed "/app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl" info 1207659093 --token="redacted" --lang=en-US --os windows
(20:23:35) ERROR:   [Gog]:             Info command failed "/app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl" info 1207659093 --token="redacted" --lang=en-US --os windows

Steps to reproduce

  1. Attempt to install a game that causes gogdl to crash. Current broken example: Ultima 9: Ascension. (this could get fixed at any time)

Expected behavior

A popup that appears showing there was an error that occurred and any relevant longs.

Screenshots

No response

System Information

SteamDeck

Heroic Version: 2.2.6 Oden Legendary Version: 0.20.25 Our Benefactors OS: Freedesktop.org KERNEL: 5.13.0-valve10.1-1-neptune-02144-g7fffaf925dfb ARCH: x64 CPU: AMD Custom APU 0405 @1.94 GOVERNOR: schedutil RAM: Total: 15.6 GB Available: 13.9 GB GRAPHICS: GPU0: Device 163f VRAM: 512MB DRIVER: PROTOCOL: x11

Additional information

I have filed another bug for the gogdl issue that appeared here, but this is a separate problem.

https://github.com/Heroic-Games-Launcher/heroic-gogdl/issues/2

flavioislima commented 2 years ago

@miketweaver can you test this build to confirm that it fixes it? I don't have a game that has this issue to test. https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/actions/runs/2009650997

miketweaver commented 2 years ago

mstsc_ewKk2NTfz4

It throws the error on both games I've had the issue with!

At first glance, I missed the error text, but it's there.

imLinguin commented 2 years ago

Use gogdl from testing branch, it's not updated yet in Heroic https://github.com/Heroic-Games-Launcher/heroic-gogdl/actions/runs/2006118486

miketweaver commented 2 years ago

Sorry. That error throwing was the goal of this bug. They now fail gracefully and let the user know that something went wrong.

imLinguin commented 2 years ago

Oh yes. Then consider my previous message as information for others that might run into that issue :smile: