search

Heroic-Games-Launcher / HeroicGamesLauncher

A games launcher for GOG, Amazon and Epic Games for Linux, Windows and macOS.
https://heroicgameslauncher.com
GNU General Public License v3.0
8.25k stars 433 forks source link

[2.3.0-beta.2] Unable to save game specific options without first changing view #1284

Closed ChlorideCull closed 2 years ago

ChlorideCull commented 2 years ago

Describe the bug

When trying to change game specific options by clicking the cog icon on the game, it's extremely unreliable with saving the options you've changed - I've only been able to get it to save by swapping between Log and Other on the left hand side before modifying any options.

Add logs

(12:36:11) DEBUG: [Legendary]: Running Legendary command: C:\Users\ChlorideCull\Documents_Software\HeroicBins\legendary.exe --version (12:36:17) INFO: [Legendary]: Legendary location: C:\Users\ChlorideCull\Documents_Software\HeroicBins\legendary.exe (12:36:17) INFO: [Gog]: GOGDL location: C:\Users\ChlorideCull\Documents_Software\HeroicBins\gogdl.exe (12:36:17) INFO: [Backend]:
Heroic Version: 2.3.0-beta.2 Caesar Clown Legendary Version: 0.20.25 Our Benefactors OS: Microsoft Windows 10 Enterprise KERNEL: 10.0.19044 ARCH: x64 CPU: AMD Ryzen 5 3600 6-Core Processor @3.6 RAM: Total: 15.91 GiB Available: 7.35 GiB GRAPHICS: GPU0: NVIDIA GeForce RTX 3070 VRAM: 8192MB DRIVER: 496.49

(12:36:17) INFO: [Gog]: Getting data about the user (12:36:17) INFO: [Gog]: Refreshing access_token (12:36:18) WARNING: [Backend]: Protocol already registered. (12:36:18) INFO: [Legendary]: Installed game list updated (12:36:18) INFO: [Gog]: Token refreshed successfully (12:36:18) INFO: [Gog]: Saved user data to config (12:36:19) INFO: [Frontend]: Refreshing Library (12:36:19) INFO: [Legendary]: Refreshing library... (12:36:19) INFO: [Gog]: Getting GOG library (12:36:19) INFO: [Legendary]: Refreshing Epic Games... (12:36:19) INFO: [Legendary]: Refreshing Epic Games... (12:36:19) INFO: [Gog]: Number of library pages: 2 (12:36:19) INFO: [Gog]: Getting data for page 2 (12:36:19) DEBUG: [Legendary]: Running Legendary command: C:\Users\ChlorideCull\Documents_Software\HeroicBins\legendary.exe list (12:36:20) INFO: [Gog]: Saved games data (12:36:21) INFO: [Legendary]: Updating game list (12:36:21) INFO: [Legendary]: Game List Updated (12:36:21) INFO: [Legendary]: Checking for game updates: C:\Users\ChlorideCull\Documents_Software\HeroicBins\legendary.exe list-installed --check-updates --tsv (12:36:21) DEBUG: [Legendary]: Running Legendary command: C:\Users\ChlorideCull\Documents_Software\HeroicBins\legendary.exe list-installed --check-updates --tsv (12:36:23) INFO: [Legendary]: Found 1 game(s) to update (12:36:23) INFO: [Gog]: Found 0 game(s) to update (12:36:59) INFO: [Legendary]: Getting Info from Epic API

Steps to reproduce

  1. Click the settings button on a game
  2. Change an option, for example "alternative EXE"
  3. Click the back arrow in the top left
  4. Click the settings button on the same game
  5. Notice that your changed options wasn't saved
  6. Click "Log" on the left hand side
  7. Click "Other" on the left hand side
  8. Change an option, for example "alternative EXE"
  9. Click the back arrow in the top left
  10. Click the settings button on the same game
  11. Notice that your changed options were now saved

Expected behavior

Settings should be changed automatically without first requiring you to switch views.

Screenshots

Recorded a short video here.

System Information

Additional information

No response

flavioislima commented 2 years ago

Just fixed that on the latest commit. Was related to upgrading React to v18.