[GOG] Starting gog game via protocol fails, because of missing game info.

Nocccer commented 2 years ago

Describe the bug

If you start a gog game via heroic protocol hoeric://launch/<app_name> it will not launch because the gog library map is not filled yet.
With legendary it works because it has the loadFile function in electron/legendary/legendary.ts which loads all information from the game json file into the library map.

Add logs

(17:38:38) INFO:    [Legendary]:       Running command : /tmp/.mount_HeroicNQmA2b/resources/app.asar.unpacked/build/bin/linux/legendary --version
(17:38:39) INFO:    [Legendary]:       Legendary location: /tmp/.mount_HeroicNQmA2b/resources/app.asar.unpacked/build/bin/linux/legendary
(17:38:39) INFO:    [Gog]:             GOGDL location: /tmp/.mount_HeroicNQmA2b/resources/app.asar.unpacked/build/bin/linux/gogdl
(17:38:39) INFO:    [Backend]:         

Heroic Version: 2.4.0-beta Caesar Clown
Legendary Version:  0.20.26 Dark Energy
OS: Pop KERNEL: 5.17.5-76051705-generic ARCH: x64
CPU: AMD Ryzen 7 3700X 8-Core Processor @3.6 GOVERNOR: schedutil
RAM: Total: 15.63 GiB Available: 9.82 GiB
GRAPHICS: GPU0: NVIDIA GeForce RTX 2060 SUPER VRAM: 8192MB DRIVER: 510.73.05 
PROTOCOL: x11

(17:38:39) INFO:    [Gog]:             Getting data about the user
(17:38:39) WARNING: [Backend]:         Failed to register protocol with OS.
(17:38:39) INFO:    [ProtocolHandler]: received 'heroic://launch/1486529526'
(17:38:39) ERROR:   [ProtocolHandler]: Could not receive game data for gog - 1486529526!
(17:38:39) INFO:    [Gog]:             Saved user data to config
(17:38:40) INFO:    [Frontend]:        Refreshing Library
(17:38:40) INFO:    [Legendary]:       Refreshing library...
(17:38:40) INFO:    [Legendary]:       Refreshing Epic Games...
(17:38:40) INFO:    [Gog]:             Getting GOG library
(17:38:40) INFO:    [Gog]:             Number of library pages: 1
(17:38:40) INFO:    [Gog]:             Saved games data
(17:38:40) INFO:    [Legendary]:       Running command : /tmp/.mount_HeroicNQmA2b/resources/app.asar.unpacked/build/bin/linux/legendary list
(17:38:41) INFO:    [Legendary]:       Updating game list
(17:38:41) INFO:    [Legendary]:       Game List Updated
(17:38:41) INFO:    [Legendary]:       Checking for game updates.
(17:38:41) INFO:    [Legendary]:       Running command : /tmp/.mount_HeroicNQmA2b/resources/app.asar.unpacked/build/bin/linux/legendary list-installed --check-updates --tsv
(17:38:42) INFO:    [Backend]:         Downloaded Winetricks
(17:38:42) INFO:    [Legendary]:       Found 0 game(s) to update
(17:38:43) INFO:    [Gog]:             Found 0 game(s) to update

Steps to reproduce

Install gog game
Try to start game with protocol path/to/heroic "heroic://launch/<app_name>"

Expected behavior

GOGClass has loadFile(file: string) function like legendary. This should be used in the getGameInfo(appName: string) as fallback. See legendary getGameInfo(appName: string).

Screenshots

No response

System Information

OS [e. g. "Ubuntu"]:
Heroic Version [e. g. 2.1.1]:

Additional information

No response

arielj commented 2 years ago

Are you using the main branch or the beta branch? we used to use a timeout of 3 seconds before processing the argument but I changed that on the main branch to wait for the frontend to be ready, can you confirm if this behaves differently between the beta and main (beta is still using the 3s timeout instead of waiting for the frontend I think)

For reference: https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/pull/1501

arielj commented 2 years ago

nevermind, I saw the comments on discord

Heroic-Games-Launcher / HeroicGamesLauncher