Add an option for a wrapper around legendary

[jimmon89]

Problem description

legendary has an open issue to add a rate limiter on downloads, but it's low priority and it's unknown when they will add it in.

Feature description

add the ability to use a wrapper with legendary then i could easily use an application like trickle to limit the download speed of legendary with a wrapper like so. trickle -u 48 -d 512 *application to be launched* *applications arguments* which will limit the download speed per worker to 512 kilobytes per second and limit the upload speed to 48 kilobytes per second which is very helpful when you have garbage internet(1.5 kilobytes per second) and 2 gamers on the connection

Alternatives

No response

Additional information

i'm on linux, so i would prefer linux support, but other platforms could likely find a use for it as well

[arielj]

meanwhile, as a workaround, I think you can make simple bash script to wrap the legendary's binary and set that in the advance settings in heroic, might work until somebody implements this in heroic

[jimmon89]

I've been tinkering since i posted that issue and can't seem to get legendary to respect trickle but I'm not sure yet if the fault is on legendary or trickle at this point in time. I'll update if/when i find the problem.

--Edit--

the problem seems to be on trickles end by using an updated version of it from a fork some one made(do as i say not as i do, i can't say if it's safe and I won't name the fork i used) it seems to be working now, however that leads to a major issue... from how i understand it, the "official" fork of trickle has problems with certain sockets as noted in this debian bug report and the original maintainer stepped away from the project. so it seems to be on distro maintainers to backport patches to fix it, and my fedora 36 based distro doesn't seem to have applied any patches to it.

windows users could potentially benefit from a wrapper around legendary for their own purposes, and some other linux distros theoretically could as well. but as far as the average linux user wanting it to use with trickle, YMMV

if a maintainer of heroic launcher decides to close this i won't be upset. i have it working on my system using the alternative legendary binary and an unofficial build of trickle i compiled myself. so as far as i'm concerned, it would be no skin off of my chest if this feature request was set as "low priority" if it needs to be.