Heroic-Games-Launcher / HeroicGamesLauncher

A games launcher for GOG, Amazon and Epic Games for Linux, Windows and macOS.
https://heroicgameslauncher.com
GNU General Public License v3.0
8.12k stars 425 forks source link

V2.6.2 custom default installation path not working (Steam Deck) #2431

Closed KillzXGaming closed 1 year ago

KillzXGaming commented 1 year ago

Describe the bug

This settings doesn't seem to work in the latest version of flatpak. This occurs in both desktop and gaming mode on steam deck. The path saves, but installing a game always shows default path. /home/deck/Games/Heroic

Add logs

(18:43:40) INFO:    [Connection]:       Connectivity: check-online
(18:43:40) INFO:    [Connection]:       Pinging external endpoints
(18:43:40) INFO:    [Legendary]:        Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary --version
(18:43:40) INFO:    [Legendary]:        Legendary location: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary
(18:43:40) INFO:    [Gog]:              GOGDL location: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
(18:43:40) INFO:    [Gog]:              GOGDL location: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
(18:43:40) WARNING: [Backend]:          Failed to register protocol with OS.
(18:43:40) INFO:    [Gog]:              Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --version
(18:43:40) INFO:    [Connection]:       Connectivity: online
(18:43:40) INFO:    [Gog]:              Getting data about the user
(18:43:40) INFO:    [Gog]:              Refreshing access_token
(18:43:40) INFO:    [Backend]:          Loading Screen Ready
(18:43:40) INFO:    [Frontend]:         Refreshing Library
(18:43:40) INFO:    [Legendary]:        Refreshing library...
(18:43:40) INFO:    [Legendary]:        Refreshing Epic Games...
(18:43:41) INFO:    [Gog]:              Refreshing access_token
(18:43:41) INFO:    [Legendary]:        Game list updated, got 293 games & DLCs
(18:43:41) INFO:    [Backend]:          Frontend Ready
(18:43:41) INFO:    [Backend]:          

Heroic Version: 2.6.2 Trafalgar Law
Legendary Version:  0.20.32 Dark Energy (hotfix #6)
GOGdl Version: 0.6

Electron Version: 22.2.0
Chrome Version: 108.0.5359.215
NodeJS Version: 16.17.1

OS: Freedesktop SDK KERNEL: 5.13.0-valve36-1-neptune ARCH: x64
CPU: AMD Custom APU 0405 @2.64 GOVERNOR: schedutil
RAM: Total: 14.47 GiB Available: 11.99 GiB
GRAPHICS: GPU0: VanGogh [AMD Custom GPU 0405] VRAM: 512MB  
PROTOCOL: x11

(18:43:41) INFO:    [Backend]:          Checking for current version changelog
(18:43:42) INFO:    [Gog]:              Token refreshed successfully
(18:43:42) INFO:    [Gog]:              Getting GOG library
(18:43:42) INFO:    [Gog]:              Token refreshed successfully
(18:43:42) INFO:    [Backend]:          AreWeAntiCheatYet data downloaded
(18:43:42) INFO:    [Legendary]:        Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party
(18:43:42) INFO:    [Winetricks]:       Downloading Winetricks
(18:43:42) INFO:    [Gog]:              Saved user data to config
(18:43:42) INFO:    [Gog]:              Number of library pages: 1
(18:43:43) INFO:    [Gog]:              Saved games data
(18:43:43) INFO:    [Legendary]:        Checking for game updates: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party
(18:43:45) INFO:    [Legendary]:        Found 0 games to update
(18:43:45) INFO:    [Gog]:              Found 0 game(s) to update
(18:43:46) INFO:    [Backend]:          Starting the Download Queue
(18:44:06) INFO:    [ExtraGameInfo]:    Using cached ExtraGameInfo data for 2064 Read Only Memories
(18:44:06) DEBUG:   [Legendary]:        Using cached install info
(18:44:06) DEBUG:   [Legendary]:        Using cached install info
(18:44:06) DEBUG:   [Legendary]:        Using cached install info
(18:44:06) DEBUG:   [Legendary]:        Using cached install info
(18:44:08) DEBUG:   [Legendary]:        Using cached install info
(18:44:08) DEBUG:   [Backend]:          {"free":17076543488,"diskSize":49932861440,"message":"15.9 GiB / 46.5 GiB","validPath":true}
(18:44:08) DEBUG:   [Backend]:          {"free":17076543488,"diskSize":49932861440,"message":"15.9 GiB / 46.5 GiB","validPath":true}

Steps to reproduce

  1. Change the default path in the heroic settings.
  2. Attempt to install game, path always shows /home/deck/Games/Heroic folder on steam deck.

Expected behavior

Path should show the configured install path.

Screenshots

No response

Heroic Version

Latest Stable

System Information

Additional information

No response

flavioislima commented 1 year ago

Can you try restarting heroic?

KillzXGaming commented 1 year ago

I've tried restarting it along with reinstalling the flatpak.

scyto commented 1 year ago

I have same issue, when i originally installed heroic 'way back when' my default install path was /run/media/mmcblk0p1/heroicapps this is what i saw when I recently updated however at some point steam OS mounted this differently like so: /run/media/deck/e609201c-f7b5-46be-ac6b-3f996b37c02d/heroicapps

This broke all installed games (no biggie - I manually repathed their install location in the Heroic UI)

I changed my default install path to this new location, but when i try and install new games it insists on defaulting to the old location which is no longer accessible.

tl;dr Heroic is using whatever path was originally set even though the config file has been populated correctly.

This is what is in my config:

{
  "defaultSettings": {
    "checkUpdatesInterval": 10,
    "enableUpdates": false,
    "addDesktopShortcuts": false,
    "addStartMenuShortcuts": false,
    "autoInstallDxvk": false,
    "autoInstallVkd3d": false,
    "addSteamShortcuts": true,
    "preferSystemLibs": false,
    "checkForUpdatesOnStartup": false,
    "autoUpdateGames": true,
    "customWinePaths": [],
    "defaultInstallPath": "/run/media/deck/e609201c-f7b5-46be-ac6b-3f996b37c02d/heroicapps",
    "libraryTopSection": "disabled",
    "defaultSteamPath": "/home/deck/.steam/steam",
    "defaultWinePrefix": "/home/deck/Games/Heroic/Prefixes",
    "hideChangelogsOnStartup": false,
    "language": "en",
    "maxWorkers": 0,
    "minimizeOnLaunch": true,
    "nvidiaPrime": false,
    "enviromentOptions": [],
    "wrapperOptions": [],
    "showFps": false,
    "useGameMode": false,
    "userInfo": {
      "epicId": "redacted",
      "name": "deck"
    },
    "wineCrossoverBottle": "Heroic",
    "winePrefix": "/home/deck/.wine",
    "wineVersion": {
      "bin": "/home/deck/.local/share/Steam/compatibilitytools.d/GE-Proton7-24/proton",
      "name": "Proton - GE-Proton7-24",
      "type": "proton"
    },
    "altLegendaryBin": "",
    "altGogdlBin": "",
    "disableController": false,
    "egsLinkedPath": "",
    "maxRecentGames": 5,
    "otherOptions": "",
    "showUnrealMarket": false
  },
  "version": "v0"
}

heroic logs

(deck@steamdeck ~)$ flatpak run com.heroicgameslauncher.hgl
Gtk-Message: 20:17:46.196: Failed to load module "canberra-gtk-module"
[3:0208/201746.240949:ERROR:bus.cc(399)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
[3:0208/201746.241127:ERROR:bus.cc(399)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
(20:17:46) INFO:    [Connection]:       Connectivity: check-online
(20:17:46) INFO:    [Connection]:       Pinging external endpoints
which: no wine in (/app/bin:/app/bin:/app/utils/bin:/usr/bin:/usr/lib/extensions/vulkan/MangoHud/bin:/usr/lib/extensions/vulkan/OBSVkCapture/bin:/app/bin/heroic/resources/app.asar.unpacked/build/bin/linux)
(20:17:46) INFO:    [Legendary]:        Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary --version
(20:17:46) INFO:    [Legendary]:        Legendary location: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary
(20:17:46) INFO:    [Gog]:              GOGDL location: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
(20:17:46) INFO:    [Gog]:              GOGDL location: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
APPIMAGE env is not defined, current application is not an AppImage
LaunchProcess: failed to execvp:
xdg-settings
(20:17:46) WARNING: [Backend]:          Failed to register protocol with OS.
[3:0208/201746.449629:ERROR:browser_main_loop.cc(271)] Gtk: gtk_widget_add_accelerator: assertion 'GTK_IS_ACCEL_GROUP (accel_group)' failed
[3:0208/201746.449749:ERROR:browser_main_loop.cc(271)] Gtk: gtk_widget_add_accelerator: assertion 'GTK_IS_ACCEL_GROUP (accel_group)' failed
[3:0208/201746.449823:ERROR:browser_main_loop.cc(271)] Gtk: gtk_widget_add_accelerator: assertion 'GTK_IS_ACCEL_GROUP (accel_group)' failed
(20:17:46) INFO:    [Connection]:       Connectivity: online
(20:17:46) INFO:    [Gog]:              Getting data about the user
(20:17:46) INFO:    [Backend]:          AreWeAntiCheatYet data downloaded
(20:17:46) INFO:    [Gog]:              Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --version
(20:17:46) INFO:    [Backend]:          Loading Screen Ready
(20:17:46) INFO:    [Frontend]:         Refreshing Library
(20:17:46) INFO:    [Legendary]:        Refreshing library...
(20:17:46) INFO:    [Legendary]:        Refreshing Epic Games...
(20:17:46) INFO:    [Legendary]:        Game list updated, got 293 games & DLCs
(20:17:46) INFO:    [Gog]:              Getting GOG library
(20:17:46) INFO:    [Backend]:          Frontend Ready
(20:17:47) INFO:    [Gog]:              Saved user data to config
hostname: invalid option -- 'f'
Try 'hostname --help' for more information.
(20:17:47) INFO:    [Legendary]:        Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party
(20:17:47) INFO:    [Backend]:          Checking for current version changelog
(20:17:47) INFO:    [Backend]:          

Heroic Version: 2.6.2 Trafalgar Law
Legendary Version:  0.20.32 Dark Energy (hotfix #6)
GOGdl Version: 0.6

Electron Version: 22.2.0
Chrome Version: 108.0.5359.215
NodeJS Version: 16.17.1

OS: Freedesktop SDK KERNEL: 6.1.9-valve2-1-neptune-61 ARCH: x64
CPU: AMD Custom APU 0405 @3.5 GOVERNOR: schedutil
RAM: Total: 14.47 GiB Available: 10.76 GiB
GRAPHICS: GPU0: VanGogh [AMD Custom GPU 0405] VRAM: 512MB  
PROTOCOL: x11

(20:17:47) INFO:    [Gog]:              Number of library pages: 1
(20:17:48) INFO:    [Gog]:              Saved games data
(20:17:48) INFO:    [Legendary]:        Checking for game updates: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party
(20:17:48) INFO:    [Winetricks]:       Downloading Winetricks
(20:17:50) INFO:    [Legendary]:        Found 0 games to update
(20:17:50) INFO:    [Gog]:              Found 0 game(s) to update
(20:17:51) INFO:    [Backend]:          Starting the Download Queue
(20:18:24) INFO:    [ExtraGameInfo]:    Using cached ExtraGameInfo data for Absolute Drift
(20:18:24) DEBUG:   [Legendary]:        Using cached install info
(20:18:24) DEBUG:   [Legendary]:        Using cached install info
(20:18:24) DEBUG:   [Legendary]:        Using cached install info
(20:18:26) DEBUG:   [Legendary]:        Using cached install info
(20:18:26) DEBUG:   [Backend]:          {"free":3096608768,"diskSize":3107340288,"message":"2.88 GiB / 2.89 GiB","validPath":false}
(20:18:26) WARNING: [Backend]:          Cannot write to "/run/media/mmcblk0p1/heroicapps": Error: EACCES: permission denied, access '/run/media'
which: no wine in (/app/bin:/app/bin:/app/utils/bin:/usr/bin:/usr/lib/extensions/vulkan/MangoHud/bin:/usr/lib/extensions/vulkan/OBSVkCapture/bin:/app/bin/heroic/resources/app.asar.unpacked/build/bin/linux)
(20:18:26) WARNING: [Backend]:          Cannot write to "/run/media/mmcblk0p1/heroicapps": Error: EACCES: permission denied, access '/run/media'
(20:18:26) DEBUG:   [Backend]:          {"free":3096608768,"diskSize":3107340288,"message":"2.88 GiB / 2.89 GiB","validPath":false}
flavioislima commented 1 year ago

Fixed upstream