search

Heroic-Games-Launcher / HeroicGamesLauncher

A games launcher for GOG, Amazon and Epic Games for Linux, Windows and macOS.
https://heroicgameslauncher.com
GNU General Public License v3.0
8.25k stars 433 forks source link

If a game finishes installing while the "cancel install" dialog is visible, the dialog stays there #2682

Open arielj opened 1 year ago

arielj commented 1 year ago

Describe the bug

When a game is being downloaded and we press the button to cancel the installation, the game continues installing. This means that the game installation can end and then we have a dialog about cancelling that finished installation.

Depending on the option selected we may end up deleting the files of the game that just finished downloading but incorrectly without doing the correct process.

Add logs

Nothing relevant on logs.

Steps to reproduce

  1. Go to the library
  2. Start installing a game
  3. Click on the button to stop the installation (either in the library, game page, or downloads page)
  4. Wait for the game to finish installing
  5. The dialog is still there and it's functional

Expected behavior

We should detect if the game installation finished and automatically close the dialog to prevent the user from clicking an action that shouldn't be used.

Screenshots

No response

Heroic Version

Latest Stable

System Information

Not relevant

Additional information

No response

flavioislima commented 1 year ago

Pausing the queue while the dialog is opened could be a good idea as well.