search

Heroic-Games-Launcher / HeroicGamesLauncher

A games launcher for GOG, Amazon and Epic Games for Linux, Windows and macOS.
https://heroicgameslauncher.com
GNU General Public License v3.0
8.32k stars 440 forks source link

Consistent GOG icons #2698

Open Rolv-Apneseth opened 1 year ago

Rolv-Apneseth commented 1 year ago

Problem description

Using a rofi, or similar launcher, with a theme that allows for bigger icons looks great for launching games (I have a repo that with a rofi plugin for this), and the icons provided for legendary games look fantastic (rectangular box art). However, the icons provided for GOG games look awful scaled up, as they are just small, circular icon files.

Feature description

I would like icons for Legendary and GOG games to be consistent, and I see the url for the box art is stored for the GOG games in the gog_library.json file under the field art_square. Would it be possible to swap out the icons currently being used with the image provided by this url, so all games can use the nice rectangular box art?

Alternatives

No response

Additional information

I am opening this issue because I'm trying to further develop my rofi plugin (link here to see what I mean about displaying the box art), and while trying to support the Heroic Games Launcher, I noticed that Legendary games display perfectly, but GOG games look terrible.

imLinguin commented 1 year ago

It's not really up to us, the only way of getting those images is gamesdb endpoint which is optimized for GOG Galaxy in terms of image sizes. It might be possible to use formatter. However formatters usually scale or crop those images so that sill might not be solution.

This goes for vertical and horizontal images.

imLinguin commented 1 year ago

Would it be possible to swap out the icons currently being used with the image provided by this url, so all games can use the nice rectangular box art?

I believe we use all images heroic puts into the config files. So I don't quite understand what do you mean. Could you give some example?

Rolv-Apneseth commented 1 year ago

Would it be possible to swap out the icons currently being used with the image provided by this url, so all games can use the nice rectangular box art?

I believe we use all images heroic puts into the config files. So I don't quite understand what do you mean. Could you give some example?

I mean while you do use this image, you don't use it as the image placed in the icons folder i.e. the image used for .desktop entries. The images that currently get placed in the icons folder for GOG games do not match the nice rectangular images placed in that folder for Legendary games, I and believe it would be a lot nicer if they did.