Heroic-Games-Launcher / HeroicGamesLauncher

A games launcher for GOG, Amazon and Epic Games for Linux, Windows and macOS.
https://heroicgameslauncher.com
GNU General Public License v3.0
7.92k stars 417 forks source link

Sideloaded apps look bad if the first element in `Recently Played` area #2892

Open arielj opened 1 year ago

arielj commented 1 year ago

Describe the bug

We only add portrait images for sideloaded apps, but we need a landscape image for that new spot in the design. Because of that, the image is cropped. See attachment:

image

Add logs

nothing relevant

Steps to reproduce

  1. Execute a sideloaded app
  2. Make sure the recently played area is enabled (same for any of the widgets we can put there)
  3. The wide item will look off

Expected behavior

The image we use should have the correct aspect ratio.

Screenshots

No response

Heroic Version

Latest Stable

System Information

not relevant

Additional information

This will also come in handy for the redesign, since in the new game page we use a landscape image too and this problem will happen there too

imLinguin commented 1 year ago

Similar story is happening for Amazon Games

imLinguin commented 1 year ago

For games like Amazon Games we can use gamesdb, but for sideloaded apps I think we should use steamgriddb API. I already added functionality for https://github.com/bottlesdevs/steamgrid-proxy/ allowing to specify image type, updated version isn't hosted by Bottles team, so we would need to host it on our own