Window goes blank after typing '++' on Winetricks search bar

JavMatz commented 9 months ago

Describe the bug

When going into the Winetricks section for a game typing ++ on the search bar the window goes "blank"

Add logs

[13:0102/122311.489645:ERROR:bus.cc(407)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
Gtk-Message: 12:23:12.054: Failed to load module "canberra-gtk-module"
Gtk-Message: 12:23:12.054: Failed to load module "pk-gtk-module"
Gtk-Message: 12:23:12.055: Failed to load module "canberra-gtk-module"
Gtk-Message: 12:23:12.055: Failed to load module "pk-gtk-module"
[13:0102/122312.072414:ERROR:bus.cc(407)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
[13:0102/122312.072482:ERROR:bus.cc(407)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
which: no wine in (/app/bin:/app/bin:/app/utils/bin:/usr/bin:/usr/lib/extensions/vulkan/MangoHud/bin:/usr/lib/extensions/vulkan/gamescope/bin:/usr/lib/extensions/vulkan/OBSVkCapture/bin:/app/bin/heroic/resources/app.asar.unpacked/build/bin/linux)
(12:23:12) INFO:    [Legendary]:        Legendary location: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary
(12:23:12) INFO:    [Gog]:              GOGDL location: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
(12:23:12) INFO:    [Connection]:       Connectivity: check-online
(12:23:12) INFO:    [Connection]:       Pinging external endpoints
(12:23:12) INFO:    [Backend]:          DRM module staus {
  oimompecagnajdejgnnjijobebaeigek: {
    name: 'Widevine Content Decryption Module',
    status: 'new',
    version: '4.10.2710.0'
  }
}
APPIMAGE env is not defined, current application is not an AppImage
LaunchProcess: failed to execvp:
xdg-settings
(12:23:12) WARNING: [Backend]:          Failed to register protocol with OS.
[13:0102/122312.349914:ERROR:browser_main_loop.cc(275)] Gtk: gtk_widget_add_accelerator: assertion 'GTK_IS_ACCEL_GROUP (accel_group)' failed
[13:0102/122312.349952:ERROR:browser_main_loop.cc(275)] Gtk: gtk_widget_add_accelerator: assertion 'GTK_IS_ACCEL_GROUP (accel_group)' failed
[13:0102/122312.349994:ERROR:browser_main_loop.cc(275)] Gtk: gtk_widget_add_accelerator: assertion 'GTK_IS_ACCEL_GROUP (accel_group)' failed
(12:23:12) INFO:    [Connection]:       Connectivity: online
(12:23:12) INFO:    [Gog]:              Checking if login is valid
(12:23:12) INFO:    [Gog]:              Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json auth
(12:23:12) INFO:    [Backend]:          AreWeAntiCheatYet data downloaded
(12:23:12) INFO:    [Backend]:          Loading Screen Ready
(12:23:12) INFO:    [Frontend]:         Refreshing undefined Library
(12:23:12) WARNING: [Backend]:          refresh not implemented on Sideload Library Manager
(12:23:12) INFO:    [Gog]:              Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json auth
(12:23:12) INFO:    [Legendary]:        Refreshing library...
(12:23:12) INFO:    [Legendary]:        Refreshing Epic Games...
(12:23:12) INFO:    [Legendary]:        Game list updated, got 8 games & DLCs
(12:23:12) INFO:    [Backend]:          Frontend Ready
(12:23:12) INFO:    [Backend]:          Checking for current version changelog
(12:23:13) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=/home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/legendaryConfig/legendary /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party
(12:23:13) INFO:    [Gog]:              Getting GOG library
(12:23:13) INFO:    [Gog]:              Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json auth
(12:23:13) INFO:    [Gog]:              Saved username to config file
(12:23:14) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=/home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/legendaryConfig/legendary /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary --version
(12:23:14) INFO:    [Gog]:              Running command: /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json --version
(12:23:14) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=/home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/nile_config /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/nile --version
(12:23:14) INFO:    [Backend]:          
System Information:
CPU: 12x AMD Ryzen 5 4500 6-Core Processor
Memory: 16.55 GB (used: 4.73 GB)
GPUs:
  GPU 0:
    Name: Advanced Micro Devices, Inc. [AMD/ATI] Navi 23 [Radeon RX 6600/6600 XT/6600M]
    IDs: D=73ff V=1002 SD=2413 SV=148c
    Driver: amdgpu
OS: Fedora Linux 39 (Workstation Edition) (linux)

The current system is not a Steam Deck
We are running inside a Flatpak container

Software Versions:
  Heroic: 2.11.0 Kumachi
  Legendary: 0.20.33 Undue Alarm
  gogdl: 0.7.3
  Nile: 1.0.0 Jonathan Joestar

(12:23:14) INFO:    [Gog]:              Saved games data
(12:23:14) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(12:23:14) DEBUG:   [Backend]:          Unable to load Steam Libraries, libraryfolders.vdf not found
which: no wine in (/app/bin:/app/bin:/app/utils/bin:/usr/bin:/usr/lib/extensions/vulkan/MangoHud/bin:/usr/lib/extensions/vulkan/gamescope/bin:/usr/lib/extensions/vulkan/OBSVkCapture/bin:/app/bin/heroic/resources/app.asar.unpacked/build/bin/linux)
(12:23:14) DEBUG:   [Backend]:          Unable to load Steam Libraries, libraryfolders.vdf not found
which: no wine in (/app/bin:/app/bin:/app/utils/bin:/usr/bin:/usr/lib/extensions/vulkan/MangoHud/bin:/usr/lib/extensions/vulkan/gamescope/bin:/usr/lib/extensions/vulkan/OBSVkCapture/bin:/app/bin/heroic/resources/app.asar.unpacked/build/bin/linux)
(12:23:14) INFO:    [Winetricks]:       Downloading Winetricks
(12:23:14) INFO:    [Gog]:              Found 0 game(s) to update
(12:23:14) INFO:    [Legendary]:        Checking for game updates: LEGENDARY_CONFIG_PATH=/home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/legendaryConfig/legendary /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party
(12:23:15) INFO:    [DXVKInstaller]:    Updating dxvk-nvapi to: dxvk-nvapi-v0.6.4
(12:23:16) INFO:    [Legendary]:        Found 0 games to update
(12:23:17) INFO:    [WineDownloader]:   Updating wine versions info
(12:23:17) INFO:    [WineDownloader]:   Fetching upstream information...
(12:23:17) INFO:    [DownloadManager]:  Downloader: Finished downloading https://github.com/jp7677/dxvk-nvapi/releases/download/v0.6.4/dxvk-nvapi-v0.6.4.tar.gz
(12:23:17) INFO:    [DownloadManager]:  Downloader: Finished downloading https://github.com/jp7677/dxvk-nvapi/releases/download/v0.6.4/dxvk-nvapi-v0.6.4.tar.gz
(12:23:17) INFO:    [DXVKInstaller]:    downloaded dxvk-nvapi
(12:23:17) INFO:    [DXVKInstaller]:    extracting dxvk-nvapi
(12:23:17) INFO:    [Backend]:          Extracting /home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/tools/dxvk-nvapi/dxvk-nvapi-v0.6.4.tar.gz to /home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/tools/dxvk-nvapi/dxvk-nvapi-v0.6.4 using native tar
(12:23:17) ERROR:   [Backend]:          Extracting Error: tar: /home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/tools/dxvk-nvapi/dxvk-nvapi-v0.6.4: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now

(12:23:17) INFO:    [DXVKInstaller]:    dxvk-nvapi updated!
(12:23:17) INFO:    [Backend]:          Starting the Download Queue
(12:23:19) INFO:    [WineDownloader]:   wine versions updated
(12:23:19) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton-GE-Proton8-25
[52:0102/122319.579680:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times!
(12:23:19) INFO:    [Winetricks]:       Running WINEPREFIX='/home/erick/Games/Heroic/Prefixes/default/Cursed to Golf/pfx' PATH='/home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/tools/proton/Proton-GE-Proton8-25/files/bin':$PATH /home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/tools/winetricks list-installed
(12:23:19) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton-GE-Proton8-25
(12:23:19) INFO:    [Winetricks]:       Running WINEPREFIX='/home/erick/Games/Heroic/Prefixes/default/Cursed to Golf/pfx' PATH='/home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/tools/proton/Proton-GE-Proton8-25/files/bin':$PATH /home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/tools/winetricks dlls list
(12:23:22) INFO:    [Backend]:          Checking if wine version exists: Proton - Proton-GE-Proton8-25
(12:23:22) INFO:    [Winetricks]:       Running WINEPREFIX='/home/erick/Games/Heroic/Prefixes/default/Cursed to Golf/pfx' PATH='/home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/tools/proton/Proton-GE-Proton8-25/files/bin':$PATH /home/erick/.var/app/com.heroicgameslauncher.hgl/config/heroic/tools/winetricks fonts list
(12:23:27) ERROR:   [Frontend]:         [Error: Invalid regular expression: /++/: Nothing to repeat]

Steps to reproduce

Go to the settings of any game
Click on Winetricks
Wait for it to load the search bar and input '++'
See error

Expected behavior

Window should not go blank

Screenshots

Heroic Version

Latest Stable (Flatpak)

System Information

System Details Report

Report details

Date generated: 2024-01-02 13:05:34

Hardware Information:

Hardware Model: ASUSTeK COMPUTER INC. TUF B450M-PLUS GAMING
Memory: 16.0 GiB
Processor: AMD Ryzen™ 5 4500 × 12
Graphics: AMD Radeon™ RX 6600
Disk Capacity: 2.0 TB

Software Information:

Firmware Version: 4202
OS Name: Fedora Linux 39 (Workstation Edition)
OS Build: (null)
OS Type: 64-bit
GNOME Version: 45.2
Windowing System: Wayland
Kernel Version: Linux 6.6.8-200.fc39.x86_64

Additional information

No response

Nocccer commented 9 months ago

Someone how wants to work on it need to escape special characters that are also used by regex.

arielj commented 9 months ago

not sure why I implemented this as a regexp initially, replacing the use of a regexp to using a substring should be enough (we don't really want to support regexp in that field)

Heroic-Games-Launcher / HeroicGamesLauncher