search

Heroic-Games-Launcher / HeroicGamesLauncher

A games launcher for GOG, Amazon and Epic Games for Linux, Windows and macOS.
https://heroicgameslauncher.com
GNU General Public License v3.0
7.81k stars 418 forks source link

Cannot open a store page after logging in. #3569

Closed Giger22 closed 5 months ago

Giger22 commented 6 months ago

Describe the bug

After I logged in to GOG I cannot refresh and I cannot see its store page.

Add logs

No logs.

Steps to reproduce

  1. Logint to GOG.
  2. Click on Stores->GOG Store
  3. Blank screen

Expected behavior

Normal store page.

Screenshots

Screenshot

Heroic Version

Latest Stable

System Information

Additional information

No response

Giger22 commented 6 months ago

Amazon

imLinguin commented 6 months ago

Heroic redirects the store page through our partner link starting 2.13.0. As it's handled by adtraction this is what happens when the adtraction domain is blocked. We'll provide a option to disable partner links in the future

Giger22 commented 6 months ago

Yeah, you are right. I just checked and Portmaster blocked track.adtraction.com when attempting to connect.

theriverlethe commented 6 months ago

This is more likely what was going on in my case than a problem with PowerShell. Can you explain the reason for going through adtraction?

imLinguin commented 6 months ago

The partner link we got from GOG works that way. This is their way to detect what purchases were made after being redirected through such link.

8BitCerberus commented 5 months ago

Ahhh! I've been wondering why all of the sudden GOG hasn't been working. I guess it's been my Pi-hole. Do you get any benefit from the partner link, or is it only for GOG's tracking/metrics? If you are getting any percentage of sales made with the partner link I'd be happy to whitelist adtraction, but if not I'll keep it blocked and wait for the fallback workaround.

arielj commented 5 months ago

Ahhh! I've been wondering why all of the sudden GOG hasn't been working. I guess it's been my Pi-hole. Do you get any benefit from the partner link, or is it only for GOG's tracking/metrics? If you are getting any percentage of sales made with the partner link I'd be happy to whitelist adtraction, but if not I'll keep it blocked and wait for the fallback workaround.

we get a % of the games purchased if that link is followed

bnthn commented 3 months ago

It could be beneficial to provide the specific partner link e.g. inside the readme so people can add an exception to their adblockers

imLinguin commented 3 months ago

I think the modal that is shown when adtraction fails to load is clear enough about the domain.
obraz