Closed JamesMcMahon closed 5 months ago
Does this happen only when you go through game pages while the library is being refreshed?
Many requests to gamesdb during the library refresh are to be expected, though they should re-use the HTTP connection, so there shouldn't be any additional DNS queries. Believe it or not this is how GOG designed that API.
Does this happen only when you go through game pages while the library is being refreshed?
I feel like this has happened occasionally when I just boot the app and have zero user input but it seems to more reliably happen when I click a game after boot.
For reference I have 400 games in my GOG library so it's rather large. I am not sure if each game gets it on HTTP request response cycle and that if the number of calls is unbounded based on the library size / other factors.
I have since double my flood protection limit to 2,000 requests over 60 seconds and this still happens. It's pretty crazy even with the default of 1,000, I've never seen any program on Windows, MacOS or Linux trigger for the 6 or so years I've run a pihole on my local network.
I'd be curious to see if this effects other folks as well or it's something local to my setup.
@JamesMcMahon could you try the build from Pull request linked above? I think this should fix DNS flooding problem. Thanks for bringing this to our attention, somehow for the time we had this method of importing games no one really noticed the problem
Hey! Happy to test it out, will try and get to it this weekend.
Describe the bug
Heroic Games Launcher is triggering the default flood protection on my pihole. The default is set to 1,000 requests in under 60 seconds. Heroic Games Launcher appears to making upwards of 1,000 requests to GOG in less then a few seconds. Ends up trigger the flood protection and blocking my machine from DNS.
I can turn off flood protection but it seems like something is going wrong to trigger this many requests.
Add logs
Steps to reproduce
Expected behavior
Heroic Games Launcher makes less then 1,000 requests in a minute.
Screenshots
Red areas are when I booted Heroic Games Launcher.
Snippet from query log:
Not shown, lots of calls to gamesdb.gog.com.
Heroic Version
Latest Stable (Flatpak)
System Information
Operating System: openSUSE Tumbleweed 20240301 KDE Plasma Version: 5.27.10 KDE Frameworks Version: 5.115.0 Qt Version: 5.15.12 Kernel Version: 6.7.6-1-default (64-bit) Graphics Platform: Wayland Processors: 16 × AMD Ryzen 7 7800X3D 8-Core Processor Memory: 31.1 GiB of RAM Graphics Processor: AMD Radeon RX 7900 XTX Manufacturer: ASUS Heroic Version: 2.13.0
Additional information
Happy to provide any information that would help debugging this.