search

Heroic-Games-Launcher / HeroicGamesLauncher

A games launcher for GOG, Amazon and Epic Games for Linux, Windows and macOS.
https://heroicgameslauncher.com
GNU General Public License v3.0
7.91k stars 417 forks source link

Flatpak version creates "~/Games/Heroic" even if the folder is not used #3737

Open Tiagoquix opened 4 months ago

Tiagoquix commented 4 months ago

Describe the bug

I have set Heroic to use another folder rather than the defalt ~/Games/Heroic and it stills create it on start-up every time.

Add logs

Not necessary.

Steps to reproduce

  1. Set up another folder for installations.
  2. Heroic still creates ~/Games/Heroic.

Expected behavior

Should not create ~/Games/Heroic.

Screenshots

No response

Heroic Version

Latest Stable (Flatpak)

System Information

Fedora Linux 40 KDE

Additional information

The Flatpak version has too many permissions by default. It shouldn't escape the Flatpak by default.

zastrixarundell commented 3 months ago

+1 on this, steam installs the games inside of the sandbox, not on the host system. I'm also against Heroic being able to read your document to save games via syslinks

cheshirecatt commented 3 months ago

Simply go to System Preferences and then to Flatpak Permissions, then disable the create folder function and also add the permission to the new folder. image

Tiagoquix commented 3 months ago

@cheshirecatt Sure, it solves the problem, but the problem is that it shouldn't do this by default. It should ask for user consent before escaping the sandbox.

cheshirecatt commented 3 months ago

@cheshirecatt Sure, it solves the problem, but the problem is that it shouldn't do this by default. It should ask for user consent before escaping the sandbox.

In fact HGL is not the only application that does this, but I understand that it does it in case the user needs to modify some prefix, many normal users will not know the .var path, not to mention that accessing the full path all the time can be tedious, so I understand why HGL installs the games outside the .var path.

zastrixarundell commented 3 months ago

> many normal users will not know the .var path

The SteamDeck OS is the most 'normie-friendly' Linux distro which still uses ~/.local/share/Steam // .steam/Steam.

The only other launcher which I know that does this is Lutris, which is jut a bundle of user-made scripts and not an actual launcher like Heroic.

cheshirecatt commented 3 months ago

many normal users will not know the .var path

The SteamDeck OS is the most 'normie-friendly' Linux distro which still uses ~/.local/share/Steam // .steam/Steam.

The only other launcher which I know that does this is Lutris, which is jut a bundle of user-made scripts and not an actual launcher like Heroic.

You already said it, Steam Deck and Steam Os, I don't have a Steam Deck and I don't use Steam OS, I use fedora and Steam through flatpak as well as Heroic.

zastrixarundell commented 3 months ago

You already said it, Steam Deck and Steam Os, I don't have a Steam Deck and I don't use Steam OS, I use fedora and Steam through flatpak as well as Heroic.

So? Neither do I? I use fedora kinoite with the steam flatpak.

My argument was that even the most user-friendly ecosystem for gaming still doesn't access any folder directly inside of home.

Heroic still shouldn't have access to create folders for Games. Sure for /run/media/X but not for ~/X.