Heroic-Games-Launcher / HeroicGamesLauncher

A games launcher for GOG, Amazon and Epic Games for Linux, Windows and macOS.
https://heroicgameslauncher.com
GNU General Public License v3.0
7.81k stars 418 forks source link

[Bug] AppImage uses wrong file picker #3792

Open krasmazov483 opened 2 months ago

krasmazov483 commented 2 months ago

Describe the bug

The AppImage version of Heroic uses the GTK file picker instead of the KDE file picker on KDE Plasma. This issue is not present on the Flatpak version of Heroic and works correctly there.

Add logs

(17:56:50) INFO:    [Legendary]:        Legendary location: /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/legendary
(17:56:50) INFO:    [Gog]:              GOGDL location: /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/gogdl
(17:56:50) INFO:    [Connection]:       Connectivity: check-online
(17:56:50) INFO:    [Connection]:       Pinging external endpoints
(17:56:50) INFO:    [Gog]:              Checking for existing gog manifests
(17:56:50) INFO:    [Nile]:             Refreshing library...
(17:56:50) INFO:    [Nile]:             Refreshing Amazon Games...
(17:56:50) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=/home/jojo/.config/heroic/nile_config /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/nile library sync
(17:56:50) INFO:    [Nile]:             Game list updated, got 431 games
(17:56:50) INFO:    [Backend]:          DRM module staus {
  "oimompecagnajdejgnnjijobebaeigek": {
    "status": "new",
    "title": "Widevine Content Decryption Module",
    "version": "4.10.2710.0"
  }
}
(17:56:51) WARNING: [Backend]:          Failed to register protocol with OS.
(17:56:51) INFO:    [Connection]:       Connectivity: online
(17:56:51) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/jojo/.config/heroic/gogdlConfig /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/jojo/.config/heroic/gog_store/auth.json auth
(17:56:51) INFO:    [Gog]:              Checking if login is valid
(17:56:51) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/jojo/.config/heroic/gogdlConfig /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/jojo/.config/heroic/gog_store/auth.json auth
(17:56:51) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=/home/jojo/.config/heroic/legendaryConfig/legendary /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/legendary --version
(17:56:51) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/jojo/.config/heroic/gogdlConfig /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/jojo/.config/heroic/gog_store/auth.json --version
(17:56:51) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=/home/jojo/.config/heroic/nile_config /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/nile --version
(17:56:51) INFO:    [Backend]:          AreWeAntiCheatYet data downloaded
(17:56:51) INFO:    [Backend]:          
System Information:
CPU: 12x AMD Ryzen 5 5600X 6-Core Processor
Memory: 16.68 GB (used: 9.72 GB)
GPUs:
  GPU 0:
    Name: Advanced Micro Devices, Inc. [AMD/ATI] Radeon RX 5700 XT Gaming OC
    IDs: D=731f V=1002 SD=2313 SV=1458
    Driver: amdgpu
OS: Nobara Linux 39 (KDE Plasma) (linux)

The current system is not a Steam Deck
We are not running inside a Flatpak container

Software Versions:
  Heroic: 2.14.1 Flame Emperor Sabo
  Legendary: 0.20.34 Direct Intervention
  gogdl: 1.0.1
  Nile: 1.0.2 Jonathan Joestar

(17:56:51) INFO:    [Nile]:             Saved user data to config file
(17:56:51) INFO:    [Frontend]:         Refreshing undefined Library
(17:56:51) WARNING: [Backend]:          refresh not implemented on Sideload Library Manager
(17:56:51) INFO:    [Legendary]:        Refreshing library...
(17:56:51) INFO:    [Legendary]:        Refreshing Epic Games...
(17:56:51) INFO:    [Nile]:             Refreshing library...
(17:56:51) INFO:    [Nile]:             Refreshing Amazon Games...
(17:56:51) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=/home/jojo/.config/heroic/nile_config /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/nile library sync
(17:56:51) INFO:    [Nile]:             Game list updated, got 431 games
(17:56:51) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/jojo/.config/heroic/gogdlConfig /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/jojo/.config/heroic/gog_store/auth.json auth
(17:56:51) INFO:    [Backend]:          Frontend Ready
(17:56:52) INFO:    [Backend]:          Checking for new Heroic Updates
(17:56:52) INFO:    [Gog]:              Getting GOG library
(17:56:52) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/jojo/.config/heroic/gogdlConfig /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/jojo/.config/heroic/gog_store/auth.json auth
(17:56:52) INFO:    [Gog]:              Saved username to config file
(17:56:52) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=/home/jojo/.config/heroic/legendaryConfig/legendary /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party
(17:56:52) INFO:    [Backend]:          Checking for current version changelog
(17:56:53) INFO:    [Winetricks]:       Downloading Winetricks
(17:56:53) INFO:    [Legendary]:        Game list updated, got 26 games & DLCs
(17:56:54) ERROR:   [ExtraGameInfo]:    Was not able to get GamesDB data for 1891038081 Release with per platform id: gog_1891038081 not found
(17:56:54) INFO:    [Gog]:              Saved games data
(17:56:54) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(17:56:54) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=/home/jojo/.config/heroic/gogdlConfig /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/gogdl --auth-config-path /home/jojo/.config/heroic/gog_store/auth.json auth
(17:56:55) INFO:    [Gog]:              Found 0 game(s) to update
(17:56:55) INFO:    [Legendary]:        Checking for game updates: LEGENDARY_CONFIG_PATH=/home/jojo/.config/heroic/legendaryConfig/legendary /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/legendary list --third-party
(17:56:55) INFO:    [WineDownloader]:   Updating wine versions info
(17:56:55) INFO:    [WineDownloader]:   Fetching upstream information...
(17:56:56) INFO:    [Backend]:          Starting the Download Queue
(17:56:56) INFO:    [Legendary]:        Found 0 games to update
(17:56:56) INFO:    [Nile]:             Looking for updates...
(17:56:56) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=/home/jojo/.config/heroic/nile_config /tmp/.mount_gearleb1VQyE/resources/app.asar.unpacked/build/bin/linux/nile list-updates --json
(17:56:57) INFO:    [WineDownloader]:   wine versions updated

Steps to reproduce

  1. Open Heroic;
  2. Click on Add Game on Library;
  3. Click to choose an executable;
  4. GTK fike picker opens, instead of KDE file picker.

Expected behavior

Heroic should use the native file picker of the DE.

Screenshots

No response

Heroic Version

Latest Stable

System Information

Additional information

No response

Etaash-mathamsetty commented 2 months ago

try GTK_USE_PORTAL=1

krasmazov483 commented 2 months ago

try GTK_USE_PORTAL=1

Still uses GTK file picker. Setting it to auto instead of 1 works and uses KDE file picker correctly.

EDIT: Spoke too soon, it sometimes works, sometimes doesn't.