search

Heroic-Games-Launcher / HeroicGamesLauncher

A games launcher for GOG, Amazon and Epic Games for Linux, Windows and macOS.
https://heroicgameslauncher.com
GNU General Public License v3.0
7.81k stars 418 forks source link

Galaxy Common Redistributables getting downloaded on every Heroic launch #3833

Closed revanmj closed 1 month ago

revanmj commented 1 month ago

Describe the bug

As title says, every time I launch Heroic, I get notification that Galaxy Common Redistributables are getting downloaded

Add logs

(18:54:17) INFO:    [Legendary]:        Legendary location: C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary
(18:54:17) INFO:    [Gog]:              GOGDL location: C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl
(18:54:17) INFO:    [Connection]:       Connectivity: check-online
(18:54:17) INFO:    [Connection]:       Pinging external endpoints
(18:54:17) INFO:    [Gog]:              Checking for existing gog manifests
(18:54:17) INFO:    [Nile]:             Refreshing library...
(18:54:17) INFO:    [Nile]:             Refreshing Amazon Games...
(18:54:18) INFO:    [Nile]:             Game list updated, got 71 games
(18:54:18) INFO:    [Backend]:          DRM module staus {
  "neifaoindggfcjicffkgpmnlppeffabd": {
    "status": "new",
    "title": "Google Widevine Windows CDM",
    "version": "1.0.2738.0"
  },
  "oimompecagnajdejgnnjijobebaeigek": {
    "status": "new",
    "title": "Widevine Content Decryption Module",
    "version": "4.10.2710.0"
  }
}
(18:54:18) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\nile_config powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\nile`"" -Wait -NoNewWindow -ArgumentList "`"library`"","`"sync`""
(18:54:18) WARNING: [Backend]:          Protocol already registered.
(18:54:18) INFO:    [Connection]:       Connectivity: online
(18:54:18) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\gogdlConfig powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl`"" -Wait -NoNewWindow -ArgumentList "`"--auth-config-path`"","`"C:\Users\revanmj\AppData\Roaming\heroic\gog_store\auth.json`"","`"auth`""
(18:54:18) INFO:    [Gog]:              Checking if login is valid
(18:54:18) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\gogdlConfig powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl`"" -Wait -NoNewWindow -ArgumentList "`"--auth-config-path`"","`"C:\Users\revanmj\AppData\Roaming\heroic\gog_store\auth.json`"","`"auth`""
(18:54:18) INFO:    [Gog]:              Updating redist, reason - new buildId
(18:54:18) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\gogdlConfig powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl`"" -Wait -NoNewWindow -ArgumentList "`"--auth-config-path`"","`"C:\Users\revanmj\AppData\Roaming\heroic\gog_store\auth.json`"","`"auth`""
(18:54:18) INFO:    [Nile]:             Saved user data to config file
(18:54:18) INFO:    [Frontend]:         Refreshing undefined Library
(18:54:18) WARNING: [Backend]:          refresh not implemented on Sideload Library Manager
(18:54:18) INFO:    [Legendary]:        Refreshing library...
(18:54:18) INFO:    [Legendary]:        Refreshing Epic Games...
(18:54:18) INFO:    [Nile]:             Refreshing library...
(18:54:18) INFO:    [Nile]:             Refreshing Amazon Games...
(18:54:18) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\nile_config powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\nile`"" -Wait -NoNewWindow -ArgumentList "`"library`"","`"sync`""
(18:54:18) INFO:    [Nile]:             Game list updated, got 71 games
(18:54:18) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\gogdlConfig powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl`"" -Wait -NoNewWindow -ArgumentList "`"--auth-config-path`"","`"C:\Users\revanmj\AppData\Roaming\heroic\gog_store\auth.json`"","`"auth`""
(18:54:18) INFO:    [Backend]:          Frontend Ready
(18:54:18) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\legendaryConfig\legendary powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary`"" -Wait -NoNewWindow -ArgumentList "`"list`"","`"--third-party`""
(18:54:18) INFO:    [Backend]:          Checking for new Heroic Updates
(18:54:18) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\legendaryConfig\legendary powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary`"" -Wait -NoNewWindow -ArgumentList "`"--version`""
(18:54:18) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\gogdlConfig powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl`"" -Wait -NoNewWindow -ArgumentList "`"--auth-config-path`"","`"C:\Users\revanmj\AppData\Roaming\heroic\gog_store\auth.json`"","`"--version`""
(18:54:18) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\nile_config powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\nile`"" -Wait -NoNewWindow -ArgumentList "`"--version`""
(18:54:19) INFO:    [Gog]:              Getting game metadata: GOGDL_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\gogdlConfig powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl`"" -Wait -NoNewWindow -ArgumentList "`"--auth-config-path`"","`"C:\Users\revanmj\AppData\Roaming\heroic\gog_store\auth.json`"","`"info`"","`"gog-redist`"","`"--os`"","`"windows`""
(18:54:19) INFO:    [Gog]:              Getting GOG library
(18:54:19) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\gogdlConfig powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl`"" -Wait -NoNewWindow -ArgumentList "`"--auth-config-path`"","`"C:\Users\revanmj\AppData\Roaming\heroic\gog_store\auth.json`"","`"auth`""
(18:54:19) INFO:    [Gog]:              Saved username to config file
(18:54:20) INFO:    [Backend]:          
System Information:
CPU: 16x AMD Ryzen 7 5700X 8-Core Processor             
Memory: 34.28 GB (used: 13.76 GB)
GPUs:
  GPU 0:
    Name: NVIDIA Corporation AD104 [GeForce RTX 4070 SUPER]
    IDs: D=2783 V=10de SD=5710 SV=19da
    Driver: 555.99
OS: Microsoft Windows 11 Pro 10.0.26100 (win32)

The current system is not a Steam Deck
We are not running inside a Flatpak container

Software Versions:
  Heroic: 2.14.1 Flame Emperor Sabo
  Legendary: 0.20.34 Direct Intervention
  gogdl: 1.0.1
  Nile: 1.0.2 Jonathan Joestar

(18:54:20) ERROR:   [Gog]:              stdout = false and res.abort = false in getInstallInfo
(18:54:20) INFO:    [DownloadManager]:  Galaxy Common Redistributables  was added to the download queue.
(18:54:20) INFO:    [Gog]:              Updating GOG redistributables
(18:54:20) INFO:    [Gog]:              GOG REDIST:: GOGDL_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\gogdlConfig powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl`"" -Wait -NoNewWindow -ArgumentList "`"--auth-config-path`"","`"C:\Users\revanmj\AppData\Roaming\heroic\gog_store\auth.json`"","`"redist`"","`"--ids`"","`"ISI`"","`"--path`"","`"C:\Users\revanmj\AppData\Roaming\heroic\tools\redist\gog`""
(18:54:20) DEBUG:   [Gog]:              Logging to file "C:\Users\revanmj\AppData\Roaming\heroic\GamesConfig\gog-redist.log"
(18:54:20) INFO:    [Backend]:          Preventing machine to sleep
(18:54:21) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\gogdlConfig powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl`"" -Wait -NoNewWindow -ArgumentList "`"--auth-config-path`"","`"C:\Users\revanmj\AppData\Roaming\heroic\gog_store\auth.json`"","`"auth`""
(18:54:22) INFO:    [DownloadManager]:  gog-redist added to download manager finished.
(18:54:22) INFO:    [DownloadManager]:  gog-redist removed from download manager.
(18:54:22) INFO:    [Backend]:          operation interrupted
(18:54:22) INFO:    [Legendary]:        Game list updated, got 217 games & DLCs
(18:54:23) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\gogdlConfig powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl`"" -Wait -NoNewWindow -ArgumentList "`"--auth-config-path`"","`"C:\Users\revanmj\AppData\Roaming\heroic\gog_store\auth.json`"","`"auth`""
(18:54:23) INFO:    [Backend]:          Starting the Download Queue
(18:54:25) INFO:    [Gog]:              Saved games data
(18:54:25) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(18:54:25) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\gogdlConfig powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl`"" -Wait -NoNewWindow -ArgumentList "`"--auth-config-path`"","`"C:\Users\revanmj\AppData\Roaming\heroic\gog_store\auth.json`"","`"auth`""
(18:54:26) INFO:    [Gog]:              Found 0 game(s) to update
(18:54:26) INFO:    [Legendary]:        Checking for game updates: LEGENDARY_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\legendaryConfig\legendary powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary`"" -Wait -NoNewWindow -ArgumentList "`"list`"","`"--third-party`""
(18:54:29) DEBUG:   [Legendary]:        Update is available for dc9d2e595d0e4650b35d659f90d41059: 1.1.0 != 1.1.1
(18:54:29) INFO:    [Legendary]:        Found 1 game to update
(18:54:29) INFO:    [Nile]:             Looking for updates...
(18:54:29) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=C:\Users\revanmj\AppData\Roaming\heroic\nile_config powershell Start-Process "`"C:\Users\revanmj\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\nile`"" -Wait -NoNewWindow -ArgumentList "`"list-updates`"","`"--json`""

Steps to reproduce

  1. Launch Heroic
  2. Check for Galaxy Common Redistributables being downloaded notification

Expected behavior

Update gets downloaded and installed properly, not on every launch

Screenshots

No response

Heroic Version

Latest Stable

System Information

Additional information

I tried launching Heroic with admin rights, it still shows that notification after relaunch.

CommandMC commented 1 month ago

Could you try downloading the gogdl binary from here and specifying it as an alternative gogdl binary in "Settings" (sidebar) -> "Advanced"?

revanmj commented 1 month ago

Yup, that fixed it. After setting this gogdl binary and restarting Heroic, notification showed up one more time, but now it does not show up anymore after further restarts, thanks!

Marocco2 commented 1 month ago

Could you try downloading the gogdl binary from here and specifying it as an alternative gogdl binary in "Settings" (sidebar) -> "Advanced"?

I can confirm that it fixed the same issue on my end :D

MrMette commented 1 month ago

If I try to set an alternative gogdl binary, I get the following error: Error running command "GOGDL_CONFIG_PATH=/home/mette/.var/app/com.heroicgameslauncher.hgl/config/heroic/gogdlConfig /home/mette/Games/HeroicBinaries/gogdl-Linux.zip --auth-config-path /home/mette/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json --version": Error: spawn ./gogdl-Linux.zip EACCES at ChildProcess._handle.onexit (node:internal/child_process:286:19) at onErrorNT (node:internal/child_process:484:16) at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

I am using the flatpak for Heroic and have tried multiple paths (and have added explicit permissions for at least one of them) and I have tried both zipped and unzipped versions of that gogdl binary. I have also tried to figure out where the binary was stored to directly overwrite the file there but since it's a flatpak I can't seem to do so.

I also noticed that the download it gives every startup says it's ?? in size, so I have a feeling it doesn't download or install because of some type of error as well.

CommandMC commented 1 month ago

Error running command "GOGDL_CONFIG_PATH=/home/mette/.var/app/com.heroicgameslauncher.hgl/config/heroic/gogdlConfig /home/mette/Games/HeroicBinaries/gogdl-Linux.zip --auth-config-path /home/mette/.var/app/com.heroicgameslauncher.hgl/config/heroic/gog_store/auth.json --version": Error: spawn ./gogdl-Linux.zip EACCES

Extract the .zip file, make sure the extracted binary is executable (for Dolphin: Right-click file -> Properties -> Permissions -> "Is executable")

MrMette commented 1 month ago

Extract the .zip file, make sure the extracted binary is executable (for Dolphin: Right-click file -> Properties -> Permissions -> "Is executable")

I don't know why I didn't think of trying to make it executable. Thank you very much, that did the job!