search

Heroic-Games-Launcher / HeroicGamesLauncher

A games launcher for GOG, Amazon and Epic Games for Linux, Windows and macOS.
https://heroicgameslauncher.com
GNU General Public License v3.0
7.94k stars 421 forks source link

Game updates silently fail when there is not enough disk space #3962

Open ahmouse15 opened 1 month ago

ahmouse15 commented 1 month ago

Describe the bug

While trying to update Fortnite, the update would start and then immediately "finish", seemingly successfully. However, the game would still show that an update was required, but trying to update it would give me the same issue. There was no error in the Heroic log under Settings, however in the C:\Users\ahmouse\AppData\Roaming\heroic\GamesConfig\Fortnite.log log file, I found an error message stating something along the lines of Installation failed. There is insufficient disk space 70GB < 74GB.

I reinstalled the game, causing the log to be deleted, so I don't have the exact log messages anymore, but it seems the failure was due to the disk space, which should be explained to the user rather than just finishing the update as if it was successful. I am not sure how to reproduce it without waiting for another update.

EDIT: It seems that this also happens when using "Force Install" when there is not enough reported space available to download the game, and then it realizes that there is not enough actual disk space. I use this because Fortnite reports the download size of the entire game including all DLCs and selective downloads, and does not adjust when users select/deselect optional content.

Add logs

(23:22:06) INFO:    [Legendary]:        Legendary location: C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\legendary
(23:22:06) INFO:    [Gog]:              GOGDL location: C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\gogdl
(23:22:06) INFO:    [Connection]:       Connectivity: check-online
(23:22:06) INFO:    [Connection]:       Pinging external endpoints
(23:22:06) INFO:    [Gog]:              Checking for existing gog manifests
(23:22:06) WARNING: [Backend]:          Protocol already registered.
(23:22:06) INFO:    [Connection]:       Connectivity: online
(23:22:06) ERROR:   [Gog]:              Unable to syncQueued playtime, userData not present
(23:22:06) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=C:\Users\ahmouse\AppData\Roaming\heroic\gogdlConfig powershell Start-Process "`"C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\gogdl`"" -Wait -NoNewWindow -ArgumentList "`"--auth-config-path`"","`"C:\\Users\\ahmouse\\AppData\\Roaming\\heroic\\gog_store\\auth.json`"","`"auth`""
(23:22:07) INFO:    [Frontend]:         Refreshing undefined Library
(23:22:07) WARNING: [Backend]:          refresh not implemented on Sideload Library Manager
(23:22:07) INFO:    [Legendary]:        Refreshing library...
(23:22:07) INFO:    [Legendary]:        Refreshing Epic Games...
(23:22:07) INFO:    [Backend]:          Frontend Ready
(23:22:07) INFO:    [Backend]:          Checking for new Heroic Updates
(23:22:07) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=C:\Users\ahmouse\AppData\Roaming\heroic\legendaryConfig\legendary powershell Start-Process "`"C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\legendary`"" -Wait -NoNewWindow -ArgumentList "`"list`"","`"--third-party`""
(23:22:07) INFO:    [Backend]:          Checking for current version changelog
(23:22:07) INFO:    [Backend]:          VCRuntime is installed
(23:22:07) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=C:\Users\ahmouse\AppData\Roaming\heroic\legendaryConfig\legendary powershell Start-Process "`"C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\legendary`"" -Wait -NoNewWindow -ArgumentList "`"--version`""
(23:22:07) INFO:    [Gog]:              Running command: GOGDL_CONFIG_PATH=C:\Users\ahmouse\AppData\Roaming\heroic\gogdlConfig powershell Start-Process "`"C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\gogdl`"" -Wait -NoNewWindow -ArgumentList "`"--auth-config-path`"","`"C:\\Users\\ahmouse\\AppData\\Roaming\\heroic\\gog_store\\auth.json`"","`"--version`""
(23:22:08) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=C:\Users\ahmouse\AppData\Roaming\heroic\nile_config powershell Start-Process "`"C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\nile`"" -Wait -NoNewWindow -ArgumentList "`"--version`""
(23:22:08) INFO:    [Legendary]:        Game list updated, got 32 games & DLCs
(23:22:08) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(23:22:08) INFO:    [Legendary]:        Checking for game updates: LEGENDARY_CONFIG_PATH=C:\Users\ahmouse\AppData\Roaming\heroic\legendaryConfig\legendary powershell Start-Process "`"C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\legendary`"" -Wait -NoNewWindow -ArgumentList "`"list`"","`"--third-party`""
(23:22:09) INFO:    [WineDownloader]:   Updating wine versions info
(23:22:09) INFO:    [WineDownloader]:   Fetching upstream information...
(23:22:09) INFO:    [Backend]:          
System Information:
CPU: 24x AMD Ryzen 9 7900X 12-Core Processor            
Memory: 67.88 GB (used: 4.54 GB)
GPUs:
  GPU 0:
    Name: Advanced Micro Devices, Inc. [AMD/ATI] Raphael
    IDs: D=164e V=1002 SD=8877 SV=1043
    Driver: 31.0.24027.1012
  GPU 1:
    Name: Advanced Micro Devices, Inc. [AMD/ATI] Navi 31 [Radeon RX 7900 XT/7900 XTX/7900M]
    IDs: D=744c V=1002 SD=2422 SV=148c
    Driver: 31.0.24027.1012
OS: Microsoft Windows 10 Pro 10.0.19045 (win32)

The current system is not a Steam Deck
We are not running inside a Flatpak container

Software Versions:
  Heroic: 2.15.1 Emeth
  Legendary: 0.20.35 Lowlife (Heroic)
  gogdl: 1.1.1
  comet: comet 0.1.2

  Nile: 1.1.1 Will A. Zeppeli

(23:22:09) INFO:    [WineDownloader]:   wine versions updated
(23:22:09) ERROR:   [Backend]:          Could not find default wine version
(23:22:10) DEBUG:   [Legendary]:        Update is available for Fortnite: ++Fortnite+Release-30.40-CL-35235494-Windows != ++Fortnite+Release-31.00-CL-35447195-Windows
(23:22:10) DEBUG:   [Legendary]:        Update is available for Fortnite_Studio: ++Fortnite+Release-30.40-CL-35235494-Windows != ++Fortnite+Release-31.00-CL-35447195-Windows
(23:22:10) INFO:    [Legendary]:        Found 2 games to update
(23:22:12) INFO:    [Backend]:          Starting the Download Queue
(23:22:20) INFO:    [Legendary]:        Getting more details with 'legendary info'
(23:22:20) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=C:\Users\ahmouse\AppData\Roaming\heroic\legendaryConfig\legendary powershell Start-Process "`"C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\legendary`"" -Wait -NoNewWindow -ArgumentList "`"info`"","`"Fortnite`"","`"--json`"","`"--platform`"","`"Windows`""
(23:22:24) INFO:    [DownloadManager]:  Fortnite  was added to the download queue.
(23:22:24) DEBUG:   [Legendary]:        Using cached install info
(23:22:24) INFO:    [Legendary]:        Updating Fortnite: LEGENDARY_CONFIG_PATH=C:\Users\ahmouse\AppData\Roaming\heroic\legendaryConfig\legendary powershell Start-Process "`"C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\legendary`"" -Wait -NoNewWindow -ArgumentList "`"update`"","`"Fortnite`"","`"-y`"","`"--skip-sdl`""
(23:22:24) DEBUG:   [Legendary]:        Logging to file "C:\Users\ahmouse\AppData\Roaming\heroic\GamesConfig\Fortnite.log"
(23:22:24) INFO:    [Backend]:          Preventing machine to sleep
(23:22:28) INFO:    [DownloadManager]:  Finished Update of Fortnite
(23:22:28) INFO:    [DownloadManager]:  Fortnite added to download manager finished.
(23:22:28) INFO:    [DownloadManager]:  Fortnite removed from download manager.
(23:22:28) INFO:    [Frontend]:         Refreshing legendary Library
(23:22:28) INFO:    [Legendary]:        Refreshing library...
(23:22:28) INFO:    [Legendary]:        Refreshing Epic Games...
(23:22:28) INFO:    [Backend]:          operation interrupted
(23:22:28) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=C:\Users\ahmouse\AppData\Roaming\heroic\legendaryConfig\legendary powershell Start-Process "`"C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\legendary`"" -Wait -NoNewWindow -ArgumentList "`"list`"","`"--third-party`""
(23:22:29) INFO:    [Legendary]:        Game list updated, got 32 games & DLCs
(23:22:29) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(23:22:29) INFO:    [Legendary]:        Checking for game updates: LEGENDARY_CONFIG_PATH=C:\Users\ahmouse\AppData\Roaming\heroic\legendaryConfig\legendary powershell Start-Process "`"C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\legendary`"" -Wait -NoNewWindow -ArgumentList "`"list`"","`"--third-party`""
(23:22:31) DEBUG:   [Legendary]:        Update is available for Fortnite: ++Fortnite+Release-30.40-CL-35235494-Windows != ++Fortnite+Release-31.00-CL-35447195-Windows
(23:22:31) DEBUG:   [Legendary]:        Update is available for Fortnite_Studio: ++Fortnite+Release-30.40-CL-35235494-Windows != ++Fortnite+Release-31.00-CL-35447195-Windows
(23:22:31) INFO:    [Legendary]:        Found 2 games to update
(23:24:22) DEBUG:   [Legendary]:        Using cached install info
(23:24:22) INFO:    [DownloadManager]:  Fortnite  was added to the download queue.
(23:24:22) DEBUG:   [Legendary]:        Using cached install info
(23:24:22) INFO:    [Legendary]:        Updating Fortnite: LEGENDARY_CONFIG_PATH=C:\Users\ahmouse\AppData\Roaming\heroic\legendaryConfig\legendary powershell Start-Process "`"C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\legendary`"" -Wait -NoNewWindow -ArgumentList "`"update`"","`"Fortnite`"","`"-y`"","`"--skip-sdl`""
(23:24:22) DEBUG:   [Legendary]:        Logging to file "C:\Users\ahmouse\AppData\Roaming\heroic\GamesConfig\Fortnite.log"
(23:24:22) INFO:    [Backend]:          Preventing machine to sleep
(23:24:26) INFO:    [DownloadManager]:  Finished Update of Fortnite
(23:24:26) INFO:    [DownloadManager]:  Fortnite added to download manager finished.
(23:24:26) INFO:    [DownloadManager]:  Fortnite removed from download manager.
(23:24:26) INFO:    [Frontend]:         Refreshing legendary Library
(23:24:26) INFO:    [Legendary]:        Refreshing library...
(23:24:26) INFO:    [Legendary]:        Refreshing Epic Games...
(23:24:26) INFO:    [Backend]:          Stopping Power Saver Blocker
(23:24:26) INFO:    [Backend]:          operation interrupted
(23:24:27) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=C:\Users\ahmouse\AppData\Roaming\heroic\legendaryConfig\legendary powershell Start-Process "`"C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\legendary`"" -Wait -NoNewWindow -ArgumentList "`"list`"","`"--third-party`""
(23:24:28) INFO:    [Legendary]:        Game list updated, got 32 games & DLCs
(23:24:28) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(23:24:28) INFO:    [Legendary]:        Checking for game updates: LEGENDARY_CONFIG_PATH=C:\Users\ahmouse\AppData\Roaming\heroic\legendaryConfig\legendary powershell Start-Process "`"C:\Users\ahmouse\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\x64\win32\legendary`"" -Wait -NoNewWindow -ArgumentList "`"list`"","`"--third-party`""
(23:24:29) DEBUG:   [Legendary]:        Update is available for Fortnite: ++Fortnite+Release-30.40-CL-35235494-Windows != ++Fortnite+Release-31.00-CL-35447195-Windows
(23:24:29) DEBUG:   [Legendary]:        Update is available for Fortnite_Studio: ++Fortnite+Release-30.40-CL-35235494-Windows != ++Fortnite+Release-31.00-CL-35447195-Windows
(23:24:29) INFO:    [Legendary]:        Found 2 games to update

Steps to reproduce

  1. Game update available
  2. Attempt to update it
  3. Update will start, then "finish" after just a few seconds
  4. Game still requires update
  5. Rinse and repeat
  6. Logs located at "C:\Users\ahmouse\AppData\Roaming\heroic\GamesConfig" will say not enough disk space

Expected behavior

User should be notified that an error occurred while updating, and should be told that there is not enough disk space to download the update, and should be shown how much space is needed vs how much is available.

Screenshots

No response

Heroic Version

Latest Stable

System Information


CPU: 24x AMD Ryzen 9 7900X 12-Core Processor            
Memory: 67.88 GB (used: 4.54 GB)
GPUs:

  GPU 0:
    Name: Advanced Micro Devices, Inc. [AMD/ATI] Raphael
    IDs: D=164e V=1002 SD=8877 SV=1043
    Driver: 31.0.24027.1012

  GPU 1:
    Name: Advanced Micro Devices, Inc. [AMD/ATI] Navi 31 [Radeon RX 7900 XT/7900 XTX/7900M]
    IDs: D=744c V=1002 SD=2422 SV=148c
    Driver: 31.0.24027.1012

OS: Microsoft Windows 10 Pro 10.0.19045 (win32)```

### Additional information

_No response_
nonetrix commented 1 week ago

Having this issue as well image image I also noticed the file path is using \ and / at the same time, I fixed that but it didn't do anything. That seems to be a bug too, but I think Windows just corrects it? Work around for me is to just click install before it checks the disk space