Heroic-Games-Launcher / HeroicGamesLauncher

A games launcher for GOG, Amazon and Epic Games for Linux, Windows and macOS.
https://heroicgameslauncher.com
GNU General Public License v3.0
8.29k stars 438 forks source link

[Fix] Delete runner configurations when resetting heroic #4033

Open Etaash-mathamsetty opened 1 month ago

Etaash-mathamsetty commented 1 month ago

Some people are having issues with nile, and have to manually delete these files, so I propose making heroic do this automatically when it is reset

Use the following Checklist if you have changed something on the Backend or Frontend:

Etaash-mathamsetty commented 1 month ago

I can't run i18n for some reason, if someone else could do it that would be great (nvm got it working)

arielj commented 1 month ago

I don't think this is a good idea. Users will be confused, then they would have to import every game after logging in?

If this is meant to workaround a problem with nile I think we should solve the problem either with nile or with the integration we have with nile (not sure if the issue is heroic or nile itself).

Etaash-mathamsetty commented 1 month ago

I don't think this is a good idea. Users will be confused, then they would have to import every game after logging in?

If this is meant to workaround a problem with nile I think we should solve the problem either with nile or with the integration we have with nile (not sure if the issue is heroic or nile itself).

It makes users more confused that resetting heroic doesn't actually reset it imo

arielj commented 1 month ago

I don't think this is a good idea. Users will be confused, then they would have to import every game after logging in? If this is meant to workaround a problem with nile I think we should solve the problem either with nile or with the integration we have with nile (not sure if the issue is heroic or nile itself).

It makes users more confused that resetting heroic doesn't actually reset it imo

Maybe the solution for that (and I think it would be a good UX improvement in general) is to have a Reset section and allow users to select what to delete. Something like:

RESET
======

- [ ] game settings                       (i)
- [ ] legendary / epic                    (i)
- [ ] nile / amazon                       (i)
- [ ] gogdl / gog                         (i)
- [ ] cache                               (i)
- [ ] something else                      (i)

[ reset ]

Then users can hover the (i) next to each item to understand what that means and decide if they want to reset that particular thing.

Etaash-mathamsetty commented 1 month ago

yea that sounds good, will implement it soon