search

Heroic-Games-Launcher / heroic-gogdl

GOG Downloading module for Heroic Games Launcher
GNU General Public License v3.0
97 stars 14 forks source link

App 1207659093 doesn't work with `info` #2

Closed miketweaver closed 2 years ago

miketweaver commented 2 years ago 
[📦 com.heroicgameslauncher.hgl ~]$ /app/bin/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl info 1207659093 --token="redacted" --lang=en-US --os windows
[API] INFO: Getting info from products endpoint for id: 1207659093
[DOWNLOAD_MANAGER] INFO: Checking compatibility of Ultimaâ„¢ 9: Ascension with windows
[DOWNLOAD_MANAGER] INFO: Game is compatible
[DOWNLOAD_MANAGER] INFO: Depot version: 1
[API] INFO: Getting Dependencies repository
[API] INFO: Getting repository manifest
Traceback (most recent call last):
  File "gogdl/cli.py", line 44, in <module>
  File "gogdl/cli.py", line 41, in main
  File "gogdl/dl/manager.py", line 43, in calculate_download_size
  File "gogdl/dl/manager.py", line 206, in collect_depots
IndexError: string index out of range
[5] Failed to execute script 'cli' due to unhandled exception!
miketweaver commented 2 years ago

A little more digging:

check if there are games that still use V1 depots and have DLCs downloadable

This one seems to be V1

imLinguin commented 2 years ago

Please test this build for both games you reported. https://github.com/Heroic-Games-Launcher/heroic-gogdl/actions/runs/2006118486

miketweaver commented 2 years ago

The test build appears to have resolved the issue for both #2 and #3.

miketweaver commented 2 years ago

@imLinguin any plans to release these fixes?

imLinguin commented 2 years ago

Yes, those will be part of next Heroic release

imLinguin commented 2 years ago

Merged to main. Like I said this will be a part of next Heroic release