search

HerringtonDarkholme / yats.vim

Yet Another TypeScript Syntax: The most advanced TypeScript Syntax Highlighting in Vim
Vim License
651 stars 67 forks source link

Yats doesn't work with rainbow #132

Open andrevmatos opened 5 years ago

andrevmatos commented 5 years ago

You mentioned https://github.com/luochen1990/rainbow here: https://github.com/HerringtonDarkholme/yats.vim/issues/124#issuecomment-512065243 but seems like Yats breaks it. I tried setting different configs at rainbow, but it always seems typescriptParens syntax definition always come first and break the plugin. image

typescriptBraces is also applied to both square and curly brackets, and don't get rainbow'ed.

cjnucette commented 4 years ago

I don't think that rainbow would be necessary if there were different groups for different braces like in pangloss/vim-javascript. That way one could highlight each case differently.

HerringtonDarkholme commented 4 years ago

Hmmm, I think remove the highlight of typescriptBraces should work. However, vim-javascript also marks braces as special group namely Noise. I don't know if I should remove the syntax group.

FallenWarrior2k commented 4 years ago

To provide some more context, because I am interested in this myself, Rainbow does apply to named imports, but nothing else in the file. image