Improvment list

[HerringtonDarkholme]

• [ ] Add typescriptFunctionCall highlight group #13
• [x] Add travis ci
• [x] Improve performance in Vue file
• [x] Simplify typescriptObjectLabel regex
• [x] Reenable typescriptProp's transparent group
• [ ] Set default value in argument list as transparent
• [x] fix return {obj: true} not highlighted in vue
• [x] methods overloading in class body
• [x] cleanup typescriptValue and typescriptExpression
• [x] update data directory to sync with yajs
• [x] simplify class/interface body highlight
• [x] unify ambient class and normal class
• [x] change type highlight color, reference -> Type, predefined -> Literal
• [ ] proper support for destructruing pattern
• [x] tsx, yup, tsx 😀😀😀😀😀

[BlakeWilliams]

Super excited to see TSX on this list! Really looking forward to trying it. :)

[FabioAntunes]

I have just subscribed to this issues.

Would it be possible, to leave a message here whenever a box gets ticked? That way people can subscribe to this and just get notified. I would love to help but unfortunately my vim scripts are really basic.

[pcflmb]

@HerringtonDarkholme, I'd love to help with TSX, would you be open to sharing any thoughts you have on how you were planning on including the XML syntax in TSX? I don't want to start work on something that wouldn't end up making it into yats.vim if I can avoid it.

[megalithic]

this is amazing.. tsx support would be the illest. yeah anything your user base might be able to help with on this?

[megalithic]

@HerringtonDarkholme is there anything we can help with? do you have a clear direction on tsx support? i'd love to contribute as this issue: https://github.com/HerringtonDarkholme/yats.vim/issues/47 affects me daily, so i'd love to contribute if you have some direction to give. :)

I'm selfishly going to /cc @mhartington to see if he has any insight/thoughts around this (might not affect him all that much since i think he's mainly in angular land)

[mhartington]

Angular and JSX/TSX these days 😄

Happy to lend a hand where I can

[megalithic]

@mhartington have you had issues with syntax rendering related to to this previously closed issue?

I reckon I'll give OceanicNext a go and see if it renders everything right.

EDIT: still the same :( -- https://cl.ly/2Y1D3s3H0Z2B

[HerringtonDarkholme]

I have already pushed a preliminary support for JSX. It still needs polish but you can try it out today.

But I'm too busy with my day job. I really don't have any time to devote in OSS...

[agarrharr]

@HerringtonDarkholme Where is the preliminary support for jsx? And how can we try it out? I don't see any branches besides master. Is it on master?

[HerringtonDarkholme]

JSX support is on master. Currently it supports basic <tag> and fragment <>.

[HerringtonDarkholme]

Current progress:

I have got fragment highlighted. Also custom component and intrinsic tag have different highlighting!

[HerringtonDarkholme]

I don't use JSX personally. Would you like recommend a good library to test highlighting?

I've searched GitHub by query: typescript + react. https://github.com/ant-design/ant-design seems like a high-starred project.

[BlakeWilliams]

Nice! Really excited to start using this soon.

I have a few snippets of JSX that I know other syntaxes have trouble with. Mostly around JSX inside of {} and template strings.

render() {
  return (
    <React.Fragment>
      {this.state.thing ? <p>Hello <strong data-role={`${this.props.prefix}-name`}>world</strong></p> : <h1>Hey!</h1>}
      <h1 className={`${this.props.baz}-class`}>wow</h1>
    </React.Fragment>
  )
}

I want to say those are what trip up a different JSX syntax for TS that I've used.

[HerringtonDarkholme]

@BlakeWilliams Thanks for report! I have fixed it!

I have opened a new issue dedicated to JSX. Please file JSX problem there so I can focus JSX stuff :)

[ghost]

Is there still no progress on typescriptFunctionCall?

[ghost]

I'd like to make a PR for it but I don't even know where to start