search

Herringway / earthbound

attempt at decompiling+porting earthbound
29 stars 7 forks source link

Window-based HDMA effects render incorrectly #128

Closed Herringway closed 1 year ago

Herringway commented 1 year ago

Buzz-buzz's appearance (ignore the AUTO and dead ness) image

Herringway commented 1 year ago

Not quite complete. Attract mode HDMA: image (note the column of pixels on the far right) Battle swirls: image

with the updated HDMA implementation, the HDMAWrite lists produced appear to be identical to what emulators produce... could this be an issue with libsfcppu? @charasyn

charasyn commented 1 year ago

Could you get HDMA and register dumps for these two examples?

From: Cameron Ross @.> Sent: Thursday, June 8, 2023 9:25:35 PM To: Herringway/earthbound @.> Cc: Cooper Harasyn @.>; Mention @.> Subject: Re: [Herringway/earthbound] Window-based HDMA effects render incorrectly (Issue #128)

Not quite complete. Attract mode HDMA: [image]https://user-images.githubusercontent.com/905162/244590791-ed05e2fd-5f45-4510-ae01-ff1c03647cd0.png (note the column of pixels on the far right) Battle swirls: [image]https://user-images.githubusercontent.com/905162/244590936-a473ba78-3f06-4bbd-99f2-d3392b423c01.png

with the updated HDMA implementation, the HDMAWrite lists produced appear to be identical to what emulators produce... could this be an issue with libsfcppu? @charasynhttps://github.com/charasyn

— Reply to this email directly, view it on GitHubhttps://github.com/Herringway/earthbound/issues/128#issuecomment-1583957712, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABOYR5KQYP4IBSBFLL3XEXLXKKQT7ANCNFSM6AAAAAAY4VARTE. You are receiving this because you were mentioned.Message ID: @.***>

Herringway commented 1 year ago

Sure. here's every single frame hdma.zip

charasyn commented 1 year ago

By manual inspection of the data with a hex editor, it looks like the HDMA tables are encoding exactly what shows up on screen. I'll try to take a look tomorrow.

Herringway commented 1 year ago

the HDMA tables for the swirls come directly from the ROM unmodified, and I've got one frame in the new HDMA unittests. those test cases were verified against mesen's HDMA implementation, so unless I'm misunderstanding something about how libsfcppu handles the HDMAWrite entries, libsfcppu is what I'm suspicious of right now.