Fix a few things relating to battles

Herringway / earthbound

attempt at decompiling+porting earthbound

29 stars 7 forks source link

Fix a few things relating to battles #157

Closed charasyn closed 11 months ago

charasyn commented 11 months ago

Avoid illegal array access in getNextTargetLeft - fixes crashing when pressing left while selecting enemy to attack
Fix issues relating to back/front row being swapped - the global variable addresses are correct here now but are wrong in ebsrc
Fix incorrect comparison resulting in enemy articles ("the") not being printed

Herringway commented 11 months ago

looks good, but I'm a bit hesitant regarding the back/front switch. how did you come to the conclusion that they were reversed?

charasyn commented 11 months ago

I confirmed using a debugger that numBattlersInFrontRow and ...BackRow are correct by inspecting $7EAD56 and 58 during a battle with two enemies in the front row and one in the back (which row is front/back checked based on the text printed while selecting which row to use PSI Fire).

I then got into a battle with one enemy, and I see that numBattlersInFrontRow == 1, $7EAD7A[0] != 0, and $7EAD82[...] == 0, meaning that $7EAD7A is frontRowBattlers.

Herringway commented 11 months ago

alright, works for me