search

Herringway / ebsrc

Source code recreation for the game Earthbound
133 stars 8 forks source link

Add offsets to the ASM source files? #22

Closed Anonymous941 closed 7 months ago

Anonymous941 commented 7 months ago

Sorry to post this as an issue, but I've been trying for a long time to add offsets to all of the lines. For example:

MENU_SETUP_SELECTED: JSL $c1f3c2 // $c1f872
UNKNOWN7: LDA #$0000 // $c1f876
JSL $c1f497 // $c1f879
CMP #$0000 // $c1f87d

I can only find the comments for the beginning of the routines.

Herringway commented 7 months ago

I am not sure what exactly it is you are asking for, but I will not be accepting any PRs that add offsets in comments. They are being phased out, as they have little value and are often inaccurate, especially for non-vanilla earthbound builds

Anonymous941 commented 7 months ago

I'm asking how I can do this not for a PR, but so I can know which offsets I can modify to change subroutines in a ROM hack. For example, how I would know which byte in the ROM I should modify in order to change the @RETURN_ALLY_GENDER subroutine in get_gender_etc.asm?

Herringway commented 7 months ago

If you modify the subroutine in the .asm file and recompile it, you'd be able to compare the ROM with a vanilla ROM and copy those changes to whatever system you're using

Anonymous941 commented 7 months ago

Oh, I see, I was approaching this the wrong way. Thanks for your help