Herringway / ebsrc

Source code recreation for the game Earthbound
133 stars 8 forks source link

Final antipiracy check identified #26

Closed lilliththecreative closed 6 months ago

lilliththecreative commented 6 months ago

Identified UNKNOWN_C3FDC5.

Herringway commented 6 months ago

At the moment, I can't really accept any assembly changes for reasons that should become very obvious very soon. I promise I'm not ignoring this right now.

lilliththecreative commented 6 months ago

Are you reverse engineering the C code?

On Sat, Feb 3, 2024 at 11:07 AM Cameron Ross @.***> wrote:

At the moment, I can't really accept any assembly changes for reasons that should become very obvious very soon. I promise I'm not ignoring this right now.

— Reply to this email directly, view it on GitHub https://github.com/Herringway/ebsrc/pull/26#issuecomment-1925397055, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2V3EGONVJLFE2WOUSO6DX3YRZVGJAVCNFSM6AAAAABCYDS6OSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGM4TOMBVGU . You are receiving this because you authored the thread.Message ID: @.***>

Herringway commented 6 months ago

that's not wrong, but it isn't right either. it should be finished in the next few days

lilliththecreative commented 6 months ago

Is it alright if I make an issue with the things I've identified so you can add them in when convenient?

On Sat, Feb 3, 2024 at 11:27 PM Cameron Ross @.***> wrote:

that's not wrong, but it isn't right either. it should be finished in the next few days

— Reply to this email directly, view it on GitHub https://github.com/Herringway/ebsrc/pull/26#issuecomment-1925587220, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2V3EGJNRS7WTPUHJADUMTLYR4L5RAVCNFSM6AAAAABCYDS6OSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGU4DOMRSGA . You are receiving this because you authored the thread.Message ID: @.***>

Herringway commented 6 months ago

Sure. leave out anything that's already documented in the port

Herringway commented 6 months ago

Taken care of by 5314ae74a0a4aab99d551ef14f599f7be7ab320e