HertzDevil / 0CC-FamiTracker

Extension of jsr's FamiTracker
http://0cc-famitracker.tumblr.com/
GNU General Public License v2.0
309 stars 32 forks source link

FDS sound all over the place #84

Open sunflowers33d opened 6 years ago

sunflowers33d commented 6 years ago

hello, when switching to version 0.3.15.3 i noticed that the FDS emulation has dropped in accuracy significantly, not on a nitpicking standpoint but a specific module i listened to that uses it the pitch is wildly wrong/all over the place.

yokai_disco_umcy_umcy.zip

it's definitely not the module itself, as it sounds fine in older/different versions of 0CC

nyanpasu64 commented 6 years ago

All previous versions of FT used an inaccurate FDS core. 0CC upgraded to a newer version, breaking many modules. Try replacing Instrument 04's modulation table with:

4 7 7 7 7 7 7 0 0 0 1 1 1 1 1 1 4 1 1 1 1 1 1 0 0 0 7 7 7 7 7 7

0cc-famitracker_2018-05-27_04-25-19

This makes the FDS instrument compatible with old AND new emulation. You can use this trick for nearly all FDS instruments.

I forked 0CC at https://github.com/jimbo1qaz/0CC-FamiTracker/releases, and changed the Sine button to generate this compatible wave. (My fork has the old inaccurate FDS emulation, it's compatible with older modules but behaves differently from hardware. Please do not rely on that behavior.)

sunflowers33d commented 6 years ago

that worked and fixed the pitch of this FDS slap bass, thanks!